Problem/Motivation

The weight selects in the tables need a label for accessibility. I attached a patch with a visually hidden label.

screen shopt of issue

CommentFileSizeAuthor
Adding_labels_to_weight_selects_for_accessibility.patch1.72 KBedmund.dunn
CleanShot 2022-09-23 at 07.41.33.png63.63 KBedmund.dunn

Issue fork inline_entity_form-3311501

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

edmund.dunn created an issue. See original summary.

edmund.dunn’s picture

edmund.dunn commented
Issue summary: View changes
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Active » Needs review

Code looks straightforward. Setting NR so bot runs.

  • podarok committed 0e05aff2 on 2.0.x authored by edmund.dunn 
    Issue #3311501 by edmund.dunn, geek-merlin: Add label to weight select...
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 8.x-1.0-rc14 » 2.0.x-dev
Status: Needs review » Fixed

tnx

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Version: 2.0.x-dev » 3.x-dev
Status: Closed (fixed) » Needs review
Related issues: +#3401656: Clean up problematic 2.x branch

Bulk reopen.

dcam made their first commit to this issue’s fork.

dcam opened merge request !97

dcam’s picture

dcam commented
Status: Needs review » Active

I converted the patch from the OP into MR 97. I removed unrelated code formatting changes and also fixed the formatting of the code additions. I'm not quite done making changes yet.

dcam’s picture

dcam commented
Status: Active » Needs review

This change replicates what Drupal\Core\Field\WidgetBase does and has the exact same effect.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Assigned: edmund.dunn » Unassigned
Status: Needs review » Reviewed & tested by the community

Yup, replicating WidgetBase can not be too wrong. No-test is fine for this.

  • geek-merlin committed 23cd78d5 on 3.x authored by dcam 
    Issue #3311501 by dcam, edmund.dunn, geek-merlin: Add label to weight...
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Reviewed & tested by the community » Fixed

Woot!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.