Problem/Motivation

Changes for this where first introduced in #2901158: Changes are lost when collapsing a paragraphs subform including an inline_entity_form. Then reverted in #3270348: Regression from #2901158.

Steps to reproduce

Create a paragraph type with an entity_reference field using inline_entity_form.
Add a paragraphs field to a node, make the paragraph type available and use paragraphs widget in 'Closed' edit mode.

Add a node with a paragraph, enter some test values and save. Edit the node again, edit the paragraph, now collapse the paragraphs subform: Your changes to the subform will be lost.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#14 47-8.patch24.74 KBvolkerk
#9 inline-entity-form_widget-state-collapsed-paragraphs-3271293-9.patch8.55 KBjansete
#8 47-8.diff6.97 KBchr.fritsch
#5 47-6.diff6.83 KBvolkerk

Issue fork inline_entity_form-3271293

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heddn created an issue. See original summary.

volkerk made their first commit to this issue’s fork.

daniel.bosen’s picture

daniel.bosen
he/him
commented

@heddn is it possible to get a failing test or some step by step instructions to reproduce the regression in #3270348: Regression from #2901158? That would be very helpful for fixing it. Thanks!

volkerk opened merge request !47

volkerk’s picture

volkerk commented
StatusFileSize
new 47-6.diff6.83 KB
szeidler’s picture

szeidler commented
Status: Active » Needs work

The patch/MR seems to not apply anymore since the recent 1.0.0-rc12 release.

chr.fritsch made their first commit to this issue’s fork.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new 47-8.diff6.97 KB
jansete’s picture

jansete commented
Issue tags: +Needs tests
StatusFileSize
new inline-entity-form_widget-state-collapsed-paragraphs-3271293-9.patch8.55 KB

With this patch, now applies to InlineEntityFormComplex, we would need tests for this as well.

silviuchingaru made their first commit to this issue’s fork.

SilviuChingaru’s picture

SilviuChingaru commented
volkerk’s picture

volkerk commented

@heddn can you elaborate on the regression you mentioned in the reverted #2901158: Changes are lost when collapsing a paragraphs subform including an inline_entity_form

This commit caused regressions with non paragraph IEF fields. I have an (albiet complex) IEF implementation for user that completely broke after this commit. Any chance this could see a revert while a test coverage and fixes are added?

I guess we need a test for this, otherwise this issue is going nowhere.

elaman’s picture

elaman
Primary language English
Location Philadelphia, United States
commented

#9 causes error with Paragraph:

TypeError: Drupal\Component\Utility\NestedArray::getValue(): Argument #2 ($parents) must be of type array, null given, called in /var/www/html/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php on line 1320 in Drupal\Component\Utility\NestedArray::getValue() (line 69 of core/lib/Drupal/Component/Utility/NestedArray.php).

volkerk’s picture

volkerk commented
StatusFileSize
new 47-8.patch24.74 KB
the_g_bomb’s picture

the_g_bomb commented
Version: 8.x-1.x-dev » 3.x-dev

Changing to target the latest branch

the_g_bomb opened merge request !133

feuerwagen made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Reading through the issue summary, isn't this a major issue with the risk of losing data unexpectedly?