Problem/Motivation
IEF works really well, but if the Group module is used on a project (e.g. for content access and permission handling), IEF can not be used within the groups context.
Steps to reproduce
- Install and enable IEF and Group modules.
- Set permissions on group level for the article bundle and remove the article permissions on global level.
- If the user is a group member, article can be accessed (but not for group outsiders).
- If using IEF to add new articles to an entity reference field, the dropdown to select the item type (article) is not shown.
- If permissions for article are set on the global level, this breaks the group permissions and makes limiting the visibility of articles to group members only impossible.
Proposed resolution
Minor modifications in IEF are necessary to enable the integration with the Group module.
- We check, if the Group module is enabled and provide a checkbox in the field widget settings "Use item in group context".
- We add a boolean value to the configuration.
- If the user selects the items to be handled in the group context, we check, whether the group is in the route and if not, whether the parent node, which holds the field with the IEF widget has one.
- We check, whether the current user has sufficient group permissions to add new items to the group. If not, we fall back to the default IEF access check.
- If the added entity is new, we create the necessary group - entity relationship. This allows the new entity to fully adhere to group permissions.
Remaining tasks
Provide a patch to introduce the above modifications.
User interface changes
Add new checkbox to the widget settings "Use item in group context".
API changes
None
Data model changes
Add a new config value "use_group".
Comments
Comment #2
jordik commentedHere is a patch, which enables IEF to be used in group context.
Would love to have the opinion of the maintainers on how to proceed further.
Comment #3
jordik commentedComment #4
jordik commentedComment #5
geek-merlinAs user of both modules, i like this. But as maintainer, my job is to not bloat the module.
This should be done in a glue module.
Of course you can and should file a task if this can not be done with existing hooks, and new ones are needed.
Comment #6
jordik commentedThank you, your answer is much appreciated.
A new hook in the function doSubmit in WidgetSubmit.php would be very helpful.
It should give modules the opportunity to react on the entity which was just saved.
For the group integration purposes the id is necessary to create the relationship, therefore we should trigger after the entity was initially saved.
What do you think about this approach? Any other ideas or paths we can explore here?
Comment #7
geek-merlinThat makes sense to me. Can you look if we already have such an issue, and if not, create something like "Add hook to allow other modules to react on IEF saved entities"?
Comment #8
jordik commentedA second hook will be necessary to give the opportunity to modify the $create_bundles array in InlineEntityFormComplex.php (Line 438).
It is the base for the dropdown list of entities to create.
Contrib modules will be able to implement custom access checks and populate this list.
Will open a separate issue for this and the hook in #7.
Comment #9
jordik commentedChecked the existing issues, could not find anything similar for 8.x-1.x.
Found a request for a save/delete hook in 7.x-1.x here: #2476505: New API hooks and rules integration for react on inline entity saves/deletes.
This gave me the idea that we can also implement a hook when an entity is not only created, but also deleted.
Comment #10
geek-merlinThanks! I'll think a bit about this...
Comment #11
jordik commentedCreated a new issue #3197629: New API hooks to react on inline entity save/delete.
Added a patch, which enables three hooks as described above. Please review!
This issue can be closed.
Comment #12
podarokas per #11