No problem on rc3, but after updating to rc5 (and doing nothing else), drush cr results in:

PHP Fatal error: Declaration of Drupal\inline_entity_form\Form\EntityInlineForm::getTableFields($bundles) must be compatible with Drupal\inline_entity_form\InlineFormInterface::getTableFields(array $bundles) in /app/web/modules/contrib/inline_entity_form/src/Form/EntityInlineForm.php on line 23

CommentFileSizeAuthor
#9 inline_entity_form-wrong_function_declarations-3135628-9.patch1.14 KBKevinVanRansbeeck
#6 inline_entity_form-wrong_function_declarations-3135628-5.patch2.09 KBjcnventura
#5 inline_entity_form-wrong_function_declarations-3135628-5.patch0 bytesjcnventura
#2 inline_entity_form-wrong_function_declarations-3135628-1.patch1.73 KBdutchyoda

Comments

jdleonard created an issue. See original summary.

dutchyoda’s picture

dutchyoda
he/him
Primary language Dutch
Location Lelystad
commented
StatusFileSize
new inline_entity_form-wrong_function_declarations-3135628-1.patch1.73 KB

I made a patch for all the wrong declarations I could find.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Status: Active » Needs review

That seems sensible, thanks. I haven't tested it.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

The code break came from the recent commit of #3135178: Fix Coding Standards , namely the changes in src/InlineFormInterface.php to the three methods:

  • getTableFields
  • isTableDragEnabled
  • delete

All of these methods now require an array to be passed. As this is a BC-breaking change, and this is past the beta stage, I'd suggest that without bumping this module to version 2.0-rc1, these changes to the interface be reverted.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new inline_entity_form-wrong_function_declarations-3135628-5.patch0 bytes

New patch that undoes the BC-breaking changes to the InlineFormInterface (and deletes an extra .rej file as a bonus).

No interdiff as this is not attempting to fix the damage caused by #3135178: Fix Coding Standards to the InlineFormInterface APIs. This undoes them, and as such restores compatibility to anything out there that might be extending IEF with it's own InlineForm classes.

If the desired way to go here is to apply #2, the version number must be bumped over to 2.0, as you're introducing BC breaks in the API.

jcnventura’s picture

jcnventura
Primary language English
commented
StatusFileSize
new inline_entity_form-wrong_function_declarations-3135628-5.patch2.09 KB

Now with a proper file.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Closed (duplicate)
Related issues: +#3135178: Fix Coding Standards

Thanks for bumping this to critical and working on this. I reverted the other commit which i was too uncritical to commit for now and we'll use this patch to critically review the other patch.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Title: "drush cr" fails after updating to IEF 1.0-rc5 » Declaration of EntityInlineForm::getTableFields($bundles) must be compatible with InlineFormInterface::getTableFields(array $bundles)

Made the title a bit more descriptive as this happens on more occasions than just drush cr.

KevinVanRansbeeck’s picture

KevinVanRansbeeck commented
StatusFileSize
new inline_entity_form-wrong_function_declarations-3135628-9.patch1.14 KB

Re-rolled patch to get my RC12 working on D8.