Closed (fixed)
Project:
Inline Entity Form
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Feb 2020 at 21:42 UTC
Updated:
6 May 2020 at 18:19 UTC
Jump to comment: Most recent
Comments
Comment #2
damienmckennaComment #3
damienmckennaSome existing work:
Comment #4
damienmckennaAlso: #3127275: Use composer.json to define test dependencies
Comment #5
damienmckennaRemoved #3112427: \Drupal calls should be avoided in classes, use dependency injection instead in src/Plugin/Field/FieldWidget/InlineEntityFormBase.php as it isn't strictly required.
Comment #6
damienmckennaWith the referenced issues the codebase passes drupal-check:
Comment #7
damienmckennaMarking this 'postponed' until the other issues are committed.
Comment #8
damienmckennaI think this is RTBC now - the main sub issues have been committed and the only one left is more of a tidy-up thing, and drupal-check doesn't report any remaining bugs! Great work everyone!
Comment #9
geek-merlin🎉 Great! 🎉
So this can be closed/fixed as there is no patch and nothing more to do?
Comment #10
damienmckennaI think so, yeah!
Comment #11
geek-merlinTa-daa!