- change "ulimited" to "unlimited"
- change "esentially" to "essentially"
- change "w/o" to "without"

// If we're using ulimited cardinality we don't display one empty item. Form
// validation will kick in if left empty which esentially means people won't
// be able to submit w/o creating another entity.

CommentFileSizeAuthor
#3 inline_patch.JPG203.89 KBkkalaskar
#3 3033713-3.patch1.2 KBkkalaskar
#2 3033713-2.patch1.2 KBgovind.maloo

Comments

oknate created an issue. See original summary.

govind.maloo’s picture

govind.maloo commented
Status: Active » Needs review
StatusFileSize
new 3033713-2.patch1.2 KB
kkalaskar’s picture

kkalaskar commented
StatusFileSize
new 3033713-3.patch1.2 KB
new inline_patch.JPG203.89 KB

Hi @govindmaloo,

I applied #2 patch on local and it works fine, but after the patch, I checked this file for code standard with following command $ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md src/Plugin/Field/FieldWidget/InlineEntityFormSimple.php
and result showing this 

 88 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 89 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters

So i fixed thoses coding standrds. I am attaching screenshot and new patch file along with this comment. Please review and let me know your thoughts on it.
Thanks.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs review » Reviewed & tested by the community

Marking RTBC. The patch applies cleanly and it fixes the issue, IMHO.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone! Committed.

  • joachim committed 874306d on 8.x-1.x authored by kkalaskar 
    Issue #3033713 by kkalaskar, govind.maloo, oknate: Fixed typo in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.