As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
4 problems (4 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#3 inline-eslint-2680985-3.patch491 bytesneelanjana das
#2 output.txt379 bytesneelanjana das

Comments

Neelanjana Das created an issue. See original summary.

neelanjana das’s picture

neelanjana das commented
StatusFileSize
new output.txt379 bytes
neelanjana das’s picture

neelanjana das commented
StatusFileSize
new inline-eslint-2680985-3.patch491 bytes
neelanjana das’s picture

neelanjana das commented
Status: Active » Needs review
neelanjana das’s picture

neelanjana das commented
Assigned: Unassigned » neelanjana das
neelanjana das’s picture

neelanjana das commented

please check the patch.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/js/inline_entity_form.js
@@ -4,12 +4,13 @@
  */
-Drupal.behaviors.inlineEntityForm = {
+  Drupal.behaviors.inlineEntityForm = {
   attach: function (context) {
     /*

This breaks the indentation ... this cannot be right :)

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs work » Closed (outdated)