Needs review
Project:
Inline
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
22 Dec 2011 at 12:55 UTC
Updated:
10 Dec 2012 at 13:40 UTC
See http://en.wikipedia.org/wiki/Comparison_of_web_browsers#Image_format_sup...
the attached patch won't hurt.
not sure it'll applies but the modification is obvious
Ideally $file->type == 'image' should imply rendering, then it's up to the browser to handle the <img>
according to the mime type it supports.
| Comment | File | Size | Author |
|---|---|---|---|
| display-bmp-svg.patch | 809 bytes | drzraf |
Comments
Comment #1
drzraf commentedComment #2
fasdalf@fasdalf.ru commentedBMP is too-damn-huge and SVG is poorly supported by browsers, so i think it's bad idea.
Comment #3
drzraf commentedI don't think there is room for arbitrary exclusion here.
If the browser does not support SVG it WILL offer to download the file or won't display it.
But not offering support for SVG by default is not a good choice, at least because some (very common) browsers DOES support (a large subset) of SVG.
BMP is actually an image format, please see
grep image/ /etc/mime.typesComment #4
fasdalf@fasdalf.ru commentedI'm agree now. After all it worths applying a patch.
Comment #5
drzraf commentedping
Comment #5.0
drzraf commented