When you put Drupal in off-line mode, there is this message that appears on every page to warn you about it. Well this message appears as well in the pop up window to insert images in TinyMCE. The problem is with the top frame to navigate to the different galleries. This off-line message causes the whole navigation to disappear and you have to scroll down to see it.
Simplest solution would be to make this frame and the whole window a little bit higher so that both the message and the navigation pull-down box remain visible.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | img_assist-DRUPAL-5.popup-header-messages.patch | 782 bytes | sun |
| #3 | img_assist_offline_msg_morerows.patch | 1.11 KB | mlsamuelson |
| #1 | img_assist_offline_message.patch | 1.09 KB | ñull |
Comments
Comment #1
ñull commentedattached a patch that makes the top frame a bit higher when in off-line mode
Comment #2
ñull commentedComment #3
mlsamuelson commentedIn Firefox 2.0 the patch works great. In IE 6 the frame needed a few more rows. Going from 60 to 70 did the trick. Patch attached. (This is my first patch, so any feedback on how the patch works would be appreciated.)
I'm unable to test with IE 7 in my current location, so feedback on that would be helpful.
I also noticed the offline message causing the same problem in the 5.x branch. I will submit an issue and patch for that.
mlsamuelson
Comment #4
mlsamuelson commentedOur would it be better to create the new issue and patch for Head? I'm not sure what the preferred route would be.
mlsamuelson
Comment #5
ñull commentedOK. This is still very bothering when you prepare a site that is off-line. I suggest another (better?) approach.
Could someone come up with a change in the CSS somewhere to turn off the
<div class="messages status">withdisplay:none;? I gave it a try myself but I did not manage to find the right one yet that would accomplish it. There seem to be so many CSS files that influence it that I lost track.Comment #6
zoo33 commentedYes, see if you can make it disappear by adding
display: noneto img_assist.css. I would definitely prefer that approach to resizing the frame. (I don't suppose you'd like to rewrite Image assist so that it doesn't use frames? That would be another option, just a little more work...)I don't personally work with content while in offline mode but I guess if you do this would be a nice improvement.
Comment #7
sunI think this can be solved easily. Please test attached patch.
Comment #8
sunIf this patch won't be tested within the next 7 days, this issue will be marked as won't fix.
Comment #9
sunFeel free to re-open this issue if you want to provide test results.
Comment #10
jasoncd commentedI applied the patch manually (Windows) and it works great. Tested using Firefox 3.5.
Comment #11
jasoncd commentedComment #12
jasoncd commentedSigh. Forgot to note that I am running 6.x-2.0-alpha4, not the 5.x that was reported by the com2. Obviously the line numbers no longer match up.
Comment #13
sunThanks for reporting, reviewing, and testing! Committed to all 2.x and 3.x branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #15
ñull commentedWould be nice when there is finally a release version that fixes this annoying bug (although it is marked as a feature). We are in 2011 now and no release was possible since August 2009?