Closed (fixed)
Project:
IMCE Tools
Version:
6.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 May 2012 at 01:38 UTC
Updated:
2 Aug 2014 at 19:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tekante commentedLooks like the problem is with the function _pm_get_project_path in drush (I'm using version 4.5) which does not like the fact that the modules bundled in the imce_tools project are in a modules directory which it thinks is referring to a reserved modules directory.
$path = _pm_find_common_path($release['project_type'], $extensions); $reserved = array('modules', 'sites', 'themes'); if ((in_array(basename($path), $reserved)) && (!in_array($name, $reserved))) { drush_log(dt('Error while trying to find the common path for enabled extensions of project !project. Extensions are: !extensions.', array('!project' => $name, '!extensions' => implode(', ', $extensions))), 'error');The values at this point in the code are:
$path: sites/all/modules/contrib/imce_tools/modules (this will vary based on your install)
$name: imce_tools
Comment #2
selwynpolit commentedSo is the solution to change the name of the modules directory to something else? That seems like a fairly easy thing to do.
Comment #3
selwynpolit commentedSo I changed the name of the sites/all/modules/imce_tools/modules to sites/all/modules/imce_tools/mods and that made drush all happy. I'll see if I can figure out how to make a patch and submit it, but for now this manual fix seems to work.
Comment #4
didaka commentedChanging the modules dir to something else works in my case as well.
Comment #5
hswong3i commentedJust similar as my following 2 modules, we don't need an additional folder wrapper for submodules:
Patch attached just move all submodules out from folder "modules" to top level for 7.x-1.x. It should works as expected.
Comment #6
hswong3i commented#5 patch works with 7.x-1.x GIT checkout, but not works with drupal.org packaged http://ftp.drupal.org/files/projects/imce_tools-7.x-1.x-dev.tar.gz, because the packaging script add some additional information at the tail of .info files.
Here is a temporary revamp of above patch, so it can works with distribution, e.g. http://drupal.org/project/drustack. Tested with above 7.x-1.x-dev.tar.gz package.
Comment #7
hswong3i commentedRefer to http://git.wikia.com/wiki/Patches, patch now created with:
git format-patch HEAD^ -M -C -s --keep-subject --stdout > ../imce_tools-rm_modules_git-1602226-7.patchTherefore able to show the rename action and so works for both GIT checkout and -dev.tar.gz package.
Comment #8
hswong3i commented#7 had been applied to DruStack for more than a month and no more error report by customers. Shall we simply push this to latest -dev?
Comment #9
dkingofpa commentedUn-assigning in the hopes this catches the attention of the module maintainers, gets committed, and we get a new release.
Comment #11
tekante commentedComment #13
estepix commentedThe same problem happens on a Drupal 6.31 install, module version 6.x-1.2. Any chance to get this fix committed for this older version as well?
should I open a new thread to track this or change this same thread to 6.x-1.2 version and set as "Active"?
thanks in advance
Comment #14
estepix commentedReopening as the same problem happens on a Drupal 6.31 install, module version 6.x-1.2. Any chance to get this fix committed for this older version as well?
Comment #16
tekante commentedCorrected with commit 4b3ecd3686b67061c7ddd65208017967b3849b24, new release should be out shortly.