I don't see why this argument isn't present already. This argument is also present in theme_image and is sometimes very useful.

CommentFileSizeAuthor
#3 imagecache_451106.patch1.01 KBdrewish
#2 imagecache_451106.patch918 bytesskilip

Comments

drewish’s picture

drewish commented

Not sure what you mean... I think the concern was adding an extra filestat to each image. You should be able to easily do it in the theme layer...

skilip’s picture

skilip commented
StatusFileSize
new imagecache_451106.patch918 bytes

theme_imagecache forces the dimensions into the image tag which IMHO should be optional, just like in theme_image.

drewish’s picture

drewish commented
StatusFileSize
new imagecache_451106.patch1.01 KB

yeah I can see the benefit of making it optional. i think we should test $getsize first so that we don't bother checking the file info if we're not going to send it.

skilip’s picture

skilip commented

Yup, that's true

drewish’s picture

drewish commented
Status: Active » Fixed

thanks, committed this plus a @param to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.