When the item is empty ('fid' = 0) and arrives to the formatter function, it first tries to load the default and then it formats it. However, there might no default as well and it tries to format it anyway generating, for instance, and empty img referece.

Same applies to imagefield, I will place the same patch for it on the project's issues.

CommentFileSizeAuthor
#6 imagecache.module.patch486 byteshanoii
imagecache.module.patch485 byteshanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Related to same bug in imagefield #260672: Imagefield field formatter is generating broken output when no actual image (or default) is available.

alippai’s picture

alippai commented
Status: Needs review » Reviewed & tested by the community

Simple, clear patch... tested...

ar-jan’s picture

ar-jan commented

Works, great!
It was quite annoying to have an 'f' show up for empty fields in a View.

masande’s picture

masande commented

i was going to suggest a similar patch until i finally found this one. tested and works as intended.

fairwind@drupal.ru’s picture

fairwind@drupal.ru commented

$item['fid'] is empty even if default image is set (leading to no default image). it's better to check $item['filename']

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Version: 5.x-2.0 » 5.x-2.1
StatusFileSize
new imagecache.module.patch486 bytes

@fairwind: Right, another problem on imagefield #310047: Field is not removed from shared content_field_XXX table on delete just led me to this issue once more and you're right about using 'filepath' for the if condition.

Attached is the new patch against new version of imagecache.

drewish’s picture

drewish commented
Status: Reviewed & tested by the community » Fixed

thanks, committed to HEAD.

drewish’s picture

drewish commented

marked #300549: hook_field_formatter, theme_imagecache as a duplicate

drewish’s picture

drewish commented

marked #280367: Don't imagecache_field_formatter() a non existent image as a duplicate

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.