Lovely module! thanks!!
it works as expected but i'm receiving a lot of warnings like this:

Notice: Undefined index: title in theme_image_caption_formatter() (line 169 of ........./sites/all/modules/image_caption_formatter/image_caption_formatter.module).

CommentFileSizeAuthor
#4 image_title_isset.patch462 bytescontrola

Comments

controla’s picture

controla commented

ok, just noticed this only happens for images with no titles. Don't know how to fix it but doesn't seem to be that much of a problem to correct.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented

too tired to patch atm but will do later if i remember.

Or @controla … would you like to try to make this patch? It's a good way to learn & get involved :)
(how to make patches with git: http://drupal.org/node/707484)

Change on line 169:

-  if ($image['title']) {
+  if (isset($image['title'])) {
controla’s picture

controla commented

will do, thanks for the push :)

controla’s picture

controla commented
Assigned: Unassigned » controla
Status: Active » Needs review
StatusFileSize
new image_title_isset.patch462 bytes

ok, here's the patch, let me know if I've nailed it.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Reviewed & tested by the community

controla++

patch works with patch < … :)

13rac1’s picture

13rac1 commented
Status: Reviewed & tested by the community » Fixed

I've been caught up on some projects, finally have time to work on this again. Thanks for the patch controla!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.