Problem/Motivation

Default value schema is missing.
Formatter schema has typos.

Steps to reproduce

See #3204574: Use the iframe field from iframe module for media iframe source plugin

Proposed resolution

Fix the schema and add the test.

Remaining tasks

  • Review.
  • Commit.
  • Rejoice.

User interface changes

None

API changes

Fixes schema

Data model changes

Fixes schema

CommentFileSizeAuthor
#3 3204981-3.patch12.64 KBjibran
#3 interdiff-24e0a4.txt6.23 KBjibran
#2 3204981-2.patch8.99 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 3204981-2.patch8.99 KB

Here we go.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-24e0a4.txt6.23 KB
new 3204981-3.patch12.64 KB

Simplified the schema file.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Contributed project blocker

This is blocking progress on https://www.drupal.org/project/media_iframe module so tagging.

  • neffets committed 7fefcfc on 8.x-2.x authored by jibran 
    Issue #3204981 by jibran: Update config schema

  • neffets committed 0cf758d on 8.x-2.x authored by jibran 
    Issue #3204981 by jibran: Update config schema, ADD test for...
neffets’s picture

neffets commented
Assigned: Unassigned » neffets

Thanx.
You added a test too. How is your commandline for a command like "Make tests", how it will be run

  • neffets committed 96132d3 on 8.x-1.x authored by jibran 
    Issue #3204981 by jibran: Update config schema, ADD test for...
neffets’s picture

neffets commented
Status: Needs review » Fixed

now in 8x-2.10 and 8.x-1.23

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Thanks for the commit and releases.

I was running the following command locally from my docroot:

vendor/bin/phpunit -c core/phpunit.xml --stop-on-failure --filter '' modules/contrib/iframe

Where core/phpunit.xml is same as core/phpunit.xml.dist but with my db and uri details.

I have the following make command as a wrapper:

FILTER?=''
CLASS?=''

test-filter:
	$(APP_ROOT)/vendor/bin/phpunit -c $(APP_ROOT)/core/phpunit.xml --stop-on-failure --filter $(FILTER) $(APP_ROOT)/$(CLASS)

Where APP_ROOT is path the the docroot.
And then I run this command from cli
make test-filter CLASS=modules/contrib/iframe

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I see there is a fatel error at https://www.drupal.org/pift-ci-job/2011897. Please run tests against D9.2.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

@neffets can you please add https://www.drupal.org/project/media_iframe to the project page?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.