Hey, what about a dev release with the latest code from github? I'd like to start working on providing a dev release for Rules-web - which builds upon your module. Also that way people are more aware of the code & the current dev status.

CommentFileSizeAuthor
#7 860574_d7_port.patch3.31 KBvoxpelli
#4 860574-http_client-d7-port.patch13.22 KBklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Subscribing. Now that we build wsclient_rest on this module, a 7.x release on d.o is really needed.

voxpelli’s picture

voxpelli commented

Subscribing - this should be coming up, if not by Hugo then by me.

voxpelli’s picture

voxpelli commented

Seems like the code isn't entirely ready - will need some more, although minor, work prior to us being able to commit a working version.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs work
StatusFileSize
new 860574-http_client-d7-port.patch13.22 KB

Ok, let's do this. Here is a straight patch for a D7 port that works for me, the code can also be found on Github: https://github.com/klausi/http_client

If you want I volunteer to maintain the 7.x branch of this module ...

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review

ups, wrong status.

voxpelli’s picture

voxpelli commented
Version: 6.x-2.0 » 6.x-2.1
Assigned: Unassigned » voxpelli
Category: bug » feature
Status: Needs review » Needs work

I find a lot of unnecessary coding style improvements in your patch.

Those should be contributed separately so that they are added to both the D6 and the D7 branch so that future patches can be applied to both branches with as small modifications as possible.

I'll take a look now and see if I can separate fixes from coding style for you. If so I'll repost two patches later today.

voxpelli’s picture

voxpelli commented
Status: Needs work » Needs review
StatusFileSize
new 860574_d7_port.patch3.31 KB

A patch containing the coding standards fixes in the previous patch here can now be found in #975852: Improved coding standards

A new patch that only contains the changes related to the porting to Drupal 7 is attached here.

Can klausi or someone else review and confirm that this patch is enough for the Drupal 7 port to work?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Works for wsclient_rest, thanks!

voxpelli’s picture

voxpelli commented
Status: Reviewed & tested by the community » Fixed

Committed - a dev-release will be up shortly.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Category: feature » task
Status: Fixed » Active

Some follow up tasks:
* Now the D6 version is in CVS head - not good. Move the 6.x code to a 6.x branch and abandon HEAD.
* Add a 7.x version option to the project issue queue
* Add a 7.x-dev tarball to the project page
* If you like: Put up the #D7CX pledge on the project page

voxpelli’s picture

voxpelli commented
Version: 6.x-2.1 » 7.x-2.x-dev

1. Ok, will fix this
2. It's there now
3. I tried to add a dev-release, but for some reasons it never gets published, tried to resave it now - lets see if that triggers something
4. Will think about it

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Still no 7.x-dev tarball - maybe you should file an issue in the infrastructure queue: http://drupal.org/node/add/project-issue/infrastructure

voxpelli’s picture

voxpelli commented

1. 6.x-2.x is no longer on HEAD - it has its own branch
3. I submitted #987176: Drupal 7 dev-release not getting generated for Http Client

voxpelli’s picture

voxpelli commented
Status: Active » Fixed

Dev release now generated - closing this again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.