Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hey, what about a dev release with the latest code from github? I'd like to start working on providing a dev release for Rules-web - which builds upon your module. Also that way people are more aware of the code & the current dev status.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 860574_d7_port.patch | 3.31 KB | voxpelli |
| #4 | 860574-http_client-d7-port.patch | 13.22 KB | klausi |
Comments
Comment #1
klausiSubscribing. Now that we build wsclient_rest on this module, a 7.x release on d.o is really needed.
Comment #2
voxpelli CreditAttribution: voxpelli commentedSubscribing - this should be coming up, if not by Hugo then by me.
Comment #3
voxpelli CreditAttribution: voxpelli commentedSeems like the code isn't entirely ready - will need some more, although minor, work prior to us being able to commit a working version.
Comment #4
klausiOk, let's do this. Here is a straight patch for a D7 port that works for me, the code can also be found on Github: https://github.com/klausi/http_client
If you want I volunteer to maintain the 7.x branch of this module ...
Comment #5
klausiups, wrong status.
Comment #6
voxpelli CreditAttribution: voxpelli commentedI find a lot of unnecessary coding style improvements in your patch.
Those should be contributed separately so that they are added to both the D6 and the D7 branch so that future patches can be applied to both branches with as small modifications as possible.
I'll take a look now and see if I can separate fixes from coding style for you. If so I'll repost two patches later today.
Comment #7
voxpelli CreditAttribution: voxpelli commentedA patch containing the coding standards fixes in the previous patch here can now be found in #975852: Improved coding standards
A new patch that only contains the changes related to the porting to Drupal 7 is attached here.
Can klausi or someone else review and confirm that this patch is enough for the Drupal 7 port to work?
Comment #8
klausiWorks for wsclient_rest, thanks!
Comment #9
voxpelli CreditAttribution: voxpelli commentedCommitted - a dev-release will be up shortly.
Comment #10
klausiSome follow up tasks:
* Now the D6 version is in CVS head - not good. Move the 6.x code to a 6.x branch and abandon HEAD.
* Add a 7.x version option to the project issue queue
* Add a 7.x-dev tarball to the project page
* If you like: Put up the #D7CX pledge on the project page
Comment #11
voxpelli CreditAttribution: voxpelli commented1. Ok, will fix this
2. It's there now
3. I tried to add a dev-release, but for some reasons it never gets published, tried to resave it now - lets see if that triggers something
4. Will think about it
Comment #12
klausiStill no 7.x-dev tarball - maybe you should file an issue in the infrastructure queue: http://drupal.org/node/add/project-issue/infrastructure
Comment #13
voxpelli CreditAttribution: voxpelli commented1. 6.x-2.x is no longer on HEAD - it has its own branch
3. I submitted #987176: Drupal 7 dev-release not getting generated for Http Client
Comment #14
voxpelli CreditAttribution: voxpelli commentedDev release now generated - closing this again.