While testing our the latest 7.x-2.x dev branch for a project, I noticed a few NOTICES while adding/editing and deleting pages (with and without homepage_example installed).

Attached is a patch for your review.

CommentFileSizeAuthor
homebox_7.x-2.x_admin_notices.patch2.57 KBblainelang

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

There are definitely a lot of PHP notices. This patch seems to apply fine. Code looks fine.

There are a few places where php notices have been squashed in issues. Must identify duplicates.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Duplicate #2022055: undefined variable caption in homebox.admin.inc

  • drumm committed 1b2745c on 7.x-2.x authored by blainelang 
    Issue #1845292: Fix PHP Notice when deleting homebox pages
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

I committed the last chunk, but couldn't reproduce the notices for the others. What steps can reproduce them?

mgifford’s picture

mgifford
he/him
Primary language English
commented

Seems like you're working on homebox today (which is great).

I can try to do some testing later to see if I can stumble across this (and other errors). Tell me if there's a better time to start evaluating what's been committed.

The issue is 2 years old, so lots may have changed...

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Closing due to lack of information.