In Change Notice https://drupal.org/node/1800686 done by #1606794: Implement new routing system hook_menu needs a graphapi.router.yml and Controller class.
This is taken care of but
So what menu change notice do we miss?
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | graphapi_admin_config_system.png | 15.42 KB | hgunicamp |
| #18 | graphapi_admin_config.png | 16.44 KB | hgunicamp |
| #17 | graphapi-whitespace_error-2143593-17-8x.patch | 4.12 KB | mgoncalves |
| #13 | graphapi-fix_config_path_and_menu-2143593-13-8x.patch | 3.91 KB | mgoncalves |
| #10 | graphapi-links_menu-2143593-10-8x.patch | 358 bytes | mgoncalves |
Comments
Comment #1
clemens.tolboomI still did not manage to get the menu visible on http://drupal.d8/admin/config.
Visiting http://drupal.d8/admin/config/system/graphapi/settings is OK
Comment #2
clemens.tolboomPartly fixed: 8c2b1101d135bfadab114fee15a0fe1c1e6111ed
Comment #3
clemens.tolboomComment #4
clemens.tolboomThe path http://drupal.d8/admin/config/system has no entry
Comment #5
clemens.tolboomComment #6
clemens.tolboomComment #7
mgoncalves commentedHello @clemens.tolboom.
I tried install and work with Graph API and I could notice the issue created in this Bug.
Even knowing that this bug is assigned to you, I fixed the issues commented.
Is missing some configuration in this module and fix another ones. But now you would be able to see the configuration page and formats page.
Don't think that I tried to pass in front of you, please...I just want help.
Let me know how can we improve this module to work fine !.
Thank you so much
Comment #8
dhruveshdtripathi commentedThe page /admin/config/system/graphapi is not showing error but still no sign of visible entry on /admin/config
Comment #9
mgoncalves commentedComment #10
mgoncalves commentedHi @dhruveshdtripathi,
I added the menu links and now you can see the link configuration on "/admin/config" and "/admin/config/system".
But we need to check....
The last link (/admin/config/system/graphapi/uml) is a path to submodule (graphapi_class).
This module has a lot reference to functions of Drupal 7.
I think in this case, the best approach is make a port to D8 or create another bug to make sure that all code inside the graphapi_class is working properly.
What do you think ?
Thanks
Comment #11
clemens.tolboomIt seems both #7 AND #10 are needed. So please make a unified patch.
Comment #12
mgoncalves commentedwork on it.
Comment #13
mgoncalves commentedhi @clemens.tolboom
As you asked, it's a unified patch.
Thank you
Comment #14
dhruveshdtripathi commentedFirst of all, last patch throws following warning:
warning: 1 line adds whitespace errors.
And point #3 in the issue description isn't solved yet. Path /admin/config/system/graphapi/uml gives 'No page found'.
Comment #15
dhruveshdtripathi commentedSorry, I missed comment #8. The remaining part is whitespace error.
Comment #16
dhruveshdtripathi commented@mgoncalves has already specified about uml tab in comment #10. Are we following that approach?
Comment #17
mgoncalves commentedHello @dhruveshdtripathi,
I fixed errors and add some commentaries missing in the file.
About the comment #10, I think yes.
We can just check with @clemens.tolboom if he agree to make a port of this sub module.
If you (@clemens.tolboom) decided to do that, you can open this port or bug with assigned to us. :)
Thank you.
Comment #18
hgunicamp commentedI tested the 'graphapi-whitespace_error-2143593-17-8x.patch' and the links are now available as we can see below.
and
I'm setting this issue to "RTBC" because it seems the "/admin/config/system/graphapi/uml" issue should be a different issue.
Comment #20
clemens.tolboomComment #21
clemens.tolboomIs there a link with #2864447: Missing configure attribute in graphapi.info.yml