Problem/Motivation

Following the official end-of-life page https://endoflife.date/drupal and https://www.drupal.org/about/core/policies/core-release-cycles/schedule Drupal 9 is not supported.

Proposed resolution

Remove it from .info file, support from ^10.6

Issue fork google_tag-3618247

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eduardo morales alberti created an issue. See original summary.

eduardo morales alberti opened merge request !145

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented

Stabilizing gitlab ci

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Related issues: +#3512549: gtag.js/gtm.js order in D10.4/D11 vs default consent

Stabilizing PHPUnit test as on issue https://www.drupal.org/project/google_tag/issues/3512549 the library does not load if there is no container id. Also added a check to ensure that the gtag libraries do not load if the container id is not set.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Assigned: eduardo morales alberti » Unassigned
Status: Active » Needs review

Tests stabilized! Ready to review!!

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Title: Drop drupal 9 from info as it reached its end of life » Stabilize gitlab CI and drop drupal 9 from info as it reached its end of life
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks, I think this should get merged to fix the tests.