I found this entry in Drupal log after upgrading to PHP 7.3
Deprecated function: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in _google_tag_status_check() (line 321 of /var/www/test/web/sites/all/modules/contrib/google_tag/google_tag.module).

CommentFileSizeAuthor
#6 google_tag-empty_needle-3024524-6-D7.patch567 bytesliam morland
#5 deprecated_function_strpos_after_upgrade_to_php_7.3-3024524-4.patch575 bytesjonas139
#3 strpos_fixes-3024524-3.patch565 bytesi-trokhanenko

Comments

langelhc created an issue. See original summary.

solotandem’s picture

solotandem commented
Version: 7.x-1.4 » 7.x-1.x-dev
Category: Bug report » Task

Thanks for reporting this PHP API change. Simple fix to follow.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Active » Needs review
StatusFileSize
new strpos_fixes-3024524-3.patch565 bytes

Please review.

drup975’s picture

drup975 commented

After applying #3 I get the following error:
Warning: strpos(): Empty needle in _google_tag_status_check() (line 321 of /home/clients//sites/all/modules/google_tag/google_tag.module)

jonas139’s picture

jonas139 commented
StatusFileSize
new deprecated_function_strpos_after_upgrade_to_php_7.3-3024524-4.patch575 bytes

I didn't applied the patch from #3 but was getting the same error as the original issue and created a simple fix for this.
Please review.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new google_tag-empty_needle-3024524-6-D7.patch567 bytes

The call to empty() is not needed because $status is sure to be set.

shaneonabike’s picture

shaneonabike commented
Status: Needs review » Reviewed & tested by the community

I can confirm that this works for me.

langelhc’s picture

langelhc commented
Issue summary: View changes

solotandem’s picture

solotandem commented
Status: Reviewed & tested by the community » Fixed

Thanks for the report and the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.