Problem/Motivation

The Web Property ID(s) field is required. This means it's impossible to remove all property ids from the site.

Steps to reproduce

Go to config page. Add Property ID. Save. Try to remove property id. Can't.

Proposed resolution

Property ID(s) field should not be required.

Issue fork google_analytics-3300761

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shawn DeArmond created an issue. See original summary.

Shawn DeArmond opened merge request !14

shawn dearmond’s picture

shawn dearmond commented
Status: Active » Needs review

I feel like I wasn't all that clear why I think this change is necessary.

I run a distribution for our university that has hundreds and hundreds of sites, and this module is enabled by default on all of them, whether they use it or not. Sometimes, a site will retire in favor of another, and will move their GA tags to the new site. They will want to keep the old site "alive" for reference, but will not want to have it registering traffic. They need to be able to remove all GA tags from their old site.

bspeare’s picture

bspeare commented
Status: Needs review » Reviewed & tested by the community

This patch works great for the ability to delete IDs.

japerry made their first commit to this issue’s fork.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

While I'm not sure removing required values is the best idea, this module is EOL and it might help set these to null to facilitate moving to Google Tag. Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.