This is the upgraded Google Analytics module for Drupal 6.x.

It's build on top of current 5.x dev, while HEAD looks somewhat out of sync.

What this patch does and additional fixes:
- numerous code style issues (read drupal code styles rules, please)
- split the settings part in small googleanalytics.admin.inc file for *speed*, like all other core modules are doing
- removes some E_ALL Notices

Please review and commit to the new DRUPAL-6 branch and release a "6.x-1.x-dev" build, please :-).

CommentFileSizeAuthor
#6 googleanalytics_D6_0.patch13.42 KBhass
googleanalytics_D6.patch14.58 KBhass

Comments

hass’s picture

hass commented

Testers: you need to manually add the string "core = 6.x" to the .info file or you cannot activate the module! If this update is committed to D6 branch, normal packaging does this job for us... so this line is not included in the patch.

hass’s picture

hass commented

Additional, the translation files directory "po" need to be renamed to "translations".

I think this is out of the scope of this upgrade patch and should be done after the commit, by "hand" in CVS.

hass’s picture

hass commented

PS: patch < googleanalytics_D6.patch

budda’s picture

budda
Primary language English
Location Cheshire
commented
Status: Needs review » Needs work

Thanks for the quick upgrade.

Just holding off doing a D6 branch until the 5.x-dev is stable and i can release an official update containing this evenings tweaks.

I was under the impression Drupal coding standards applied to patches contributed to Drupal core.
Spaces before opening parenthesis, pffft. By the way, you missed one in googleanalytics.admin.inc :-p
if(!module_exists('profile'))

hass’s picture

hass commented
Version: 5.x-1.x-dev » 7.x-1.x-dev

Now after we hopefully fixed all known code style issues... should i re-roll this patch and commit into D6 branch?

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new googleanalytics_D6_0.patch13.42 KB

updated patch attached

hass’s picture

hass commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: Unassigned »
Status: Needs review » Fixed

committed to CVS...

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)