Gmap View Plugin doesn't recognize Location CCK Field as valid lat/lon/marker source

v2.5 is an erroneous, outdated, version. Can you provide a patch against 7.x-2.x version?
It is hard to see which code is changed/reverted deliberately.
see #1955230: Tag for 7.x-2.5 is NOT correct. It publishes an OLD version!

bumping version

#1: gmap-location_field_cck-0.patch queued for re-testing.

#1 needs reroll
+

+++ b/gmap_plugin_style_gmap.incundefined
@@ -50,10 +50,10 @@ class gmap_plugin_style_gmap extends views_plugin_style {
-
+    ¶
     $options['bubbletextenabled'] = array('default' => 0);
     $options['bubbletextfield'] = array('default' => '');
-
+    ¶

+++ b/gmap_plugin_style_gmap.incundefined
@@ -102,27 +102,38 @@ class gmap_plugin_style_gmap extends views_plugin_style {
     }
-
+    ¶
     // Determine rmt field.

+++ b/gmap_plugin_style_gmap.incundefined
@@ -133,15 +144,14 @@ class gmap_plugin_style_gmap extends views_plugin_style {
+    ¶
+    // Let's make sure the individual fields are rendered ¶
     $this->render_fields($this->view->result);
-
+    ¶
     // Render each group separately and concatenate.  Plugins may override this

+++ b/gmap_plugin_style_gmap.incundefined
@@ -176,13 +186,31 @@ class gmap_plugin_style_gmap extends views_plugin_style {
+          $custom_field_lon = isset($row->{$custom_field_lonname}[0]['raw']) ? $row->{$custom_field_lonname}[0]['raw'] : NULL;
+          ¶
+          if (is_array($custom_field_lat) && !empty($custom_field_lat['latitude']))
+            $lat = (float)$custom_field_lat['latitude'];
+          ¶
+          if (is_array($custom_field_lon) && !empty($custom_field_lat['longitude']))
+            $lon = (float)$custom_field_lat['longitude'];
+          ¶
+          if ($custom_field_lat && !$lat)
+           $lat = (float)$row->{$lat_field};
+          ¶
+          if ($custom_field_lon && !$lon)

+++ b/gmap_plugin_style_gmap.incundefined
@@ -231,14 +259,26 @@ class gmap_plugin_style_gmap extends views_plugin_style {
-
+          ¶
           $bubbletext = NULL;

+++ b/gmap_plugin_style_gmap.incundefined
@@ -231,14 +259,26 @@ class gmap_plugin_style_gmap extends views_plugin_style {
+              $bubbletext_field_alias = $bubbletext_field_obj->field_alias;
+              ¶
+            if (!empty($bubbletext_field_alias) && !empty($row->{'field_'.$bubbletext_field_alias})) {

+++ b/gmap_plugin_style_gmap.incundefined
@@ -524,7 +562,7 @@ class gmap_plugin_style_gmap extends views_plugin_style {
-
+    ¶

lot of whitespace errors
http://drupal.org/coding-standards#indenting

I'm glad you did the trick, curiosity26.
Some remarks:
if (is_array($custom_field_lat) && !empty($custom_field_lat['latitude'])) {
- Isn't this always (TRUE && TRUE) for Field API fields? At least, if $custom_field_lat['latitude'] exists? This might be enough:
if (isset($custom_field_lat['latitude'])) {
- A bit of documentation wouldn't hurt, for later reference.
- you still have problems with indentation, trailing spaces and tab's. Try the Coder module. After installation, you can activate it from admin/modules page.
- IMO below (untested) version would do the trick, too.

        elseif ($this->options['datasource'] == 'fields') {
          // A default field API field.
          $lat = isset($row->{$lat_field}[0]['raw']['value']) ? (float) $row->{$lat_field}[0]['raw']['value'] : NULL;
          $lon = isset($row->{$lon_field}[0]['raw']['value']) ? (float) $row->{$lon_field}[0]['raw']['value'] : NULL;
          // A location CCK field.
          if (!$lat || !$lon) {
            $lat = isset($row->{$lat_field}[0]['raw']['latitude']) ? $row->{$lat_field}[0]['raw']['latitude'] : NULL;
            $lon = isset($row->{$lon_field}[0]['raw']['longitude']) ? $row->{$lon_field}[0]['raw']['longitude'] : NULL;
          }
          // A ... field.
          if (!$lat || !$lon) {
            $lat = (float)$row->{$lat_field};
            $lon = (float)$row->{$lon_field};
          }
        }

2 @curiosity26
If You uploading a patch , please tag it with needs review status https://drupal.org/node/156119 and latest dev version for testbot

+++ b/gmap_plugin_style_gmap.incundefined
@@ -199,6 +199,12 @@ class gmap_plugin_style_gmap extends views_plugin_style {
+	  ¶
+          // Field is Location CCK
+ 	  if (!$lat || !$lon) {

whitespace errors
http://drupal.org/coding-standards#indenting

Rerolled it.

#15 commited pushed to 7.x-2.x
this one needs rework to extended views plugin style so moving to critical!
nice work
thanks!

Just want to share my experience. I had the same problem with 7.x-2.x updated in Oct 2013.
Later my problem is solved by unchecking "Use a Google Map to set latitude and longitude" under "admin/config/content/location". It automatic enable geocoding.