Prevent git parsing on every other admin page load: implement caching [#1354756]

Traversing the 230+ git checkouts in my module folder roughly takes 50 seconds and was being run on nearly every admin page load. Therefor i implemented some caching and of course the performance gain is massive. Check it out!
Note: the diff is huge because of indention changes, try git diff --minimal --patience --color-words after applying to filter that some.
Cache validity is hard-coded to 6hours.

Comment	File	Size	Author
	git_deploy-add-caching.patch	6.95 KB	eMPee584

Comments

Comment #1

blueyed commented 20 April 2012 at 20:11

You could use filemtime(".git/") for/with the cache key, so that it invalidates itself automatically - fstat'ing should be rather cheap. This could be an entry in the module's cache entry.
Consider using strpos() instead of preg_grep() when looking for "Fetch URL:" in the output (for performance reasons).