Problem/Motivation

#3193231: Add system diff styles is closed, so this issue purely a table cell height issue noticeable on revision page.

Steps to reproduce

1. Install latest Drupal core
2. Download Gin theme and Diff module.composer require drupal/gin drupal/diff
3. Enable Gin and Diff module.
4. Create article and save.
5. Modify article fields and save.
6. Go to revisions and compare last editions, select "Split fields" layout. /node/1/revisions/view/1/2/split_fields

Proposed resolution

Consider overriding Claro theme table td setting:

td {
  height: 4rem;
}

Remaining tasks

User interface changes

Before:
before screenshot

After:

After screenshot

API changes

Data model changes

Issue fork gin-3206081

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sokru created an issue. See original summary.

saschaeggi’s picture

Status: Active » Postponed (maintainer needs more info)

Can you provide a patch for this – targeting only the diff?

sokru’s picture

Status: Postponed (maintainer needs more info) » Needs review

Opened MR for the change. Maybe we should also resolve regression from #3193231: Add system diff styles in here?

saschaeggi’s picture

Status: Needs review » Fixed

Thanks, looking good

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.