Problem/Motivation

Gin has no styles for system diff tables. This is quite observable in darkmode, where diff table is almost illegible.

Steps to reproduce

Examine differences of any changed configuration item at /admin/config/development/configuration

Proposed resolution

Add system diff styles.

Remaining tasks

Review.

User interface changes

None.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#9 gin-dev-2021-03-28.png269 KBsokru
#9 gin-alpha33.png312.99 KBsokru
#5 3193231-5.patch441.4 KBchr.fritsch
#4 3193231-4.patch441.03 KBchr.fritsch
#3 Bildschirmfoto 2021-02-16 um 11.08.01.png98.41 KBchr.fritsch
#2 gin-system_diff-3193231-2.patch440.81 KBmanuel.adan

Comments

manuel.adan created an issue. See original summary.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Title: System diff styles » Add system diff styles
Assigned: manuel.adan » Unassigned
Status: Active » Needs review
StatusFileSize
new gin-system_diff-3193231-2.patch440.81 KB
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Needs work
StatusFileSize
new Bildschirmfoto 2021-02-16 um 11.08.01.png98.41 KB

Comparing revisions looks like this in dark mode.
So that could be improved as well.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 3193231-4.patch441.03 KB

Added styling for the field-name

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new 3193231-5.patch441.4 KB

Removed the yellow color, because it's not part of the diff module either.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs review » Fixed

Thanks y'all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sokru’s picture

sokru commented
StatusFileSize
new gin-alpha33.png312.99 KB
new gin-dev-2021-03-28.png269 KB

First of all, thanks for your great effort on this important project! While I created issue for #3206081: [diff] Compare revisions with Split fields layout I noticed the latest -dev has some background color changes that might not be intentional. Visible at: /node/1/revisions/view/1/2/split_fields

Gin-alpha33:

Gin -dev