Problem/Motivation

There are some problems with the composer.json file. When "composer validate" is executed it gives this error:

Root package 'drupal/geolocation' cannot require itself in its composer.json

This comes from the require-dev lines that are unnecessary IMHO.

Steps to reproduce

Run "composer validate" in the codebase.

Proposed resolution

Remove the "require-dev" items, they're unnecessary.

Remaining tasks

tbd

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#2 geolocation-n3330861-2.patch467 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new467 bytes

After applying this patch the composer file validates correctly.

damienmckenna’s picture

Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: geolocation-n3330861-2.patch, failed testing. View results

elber’s picture

Assigned: Unassigned » elber

I will work on it.

damienmckenna’s picture

Other issues should be handled separately; see #3328967: New dependency jquery_ui_autocomplete is not automatically enabled for details.

damienmckenna’s picture

Status: Needs work » Needs review
nick hope’s picture

In case this saves someone else a few minutes of confusion... These require-dev lines are only in composer.json 8.x-3.x-dev. They are not in 8.x-3.11.

elber’s picture

Assigned: elber » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi I aplied the patch and now composer.json is valid . I think the tests are breaking because is missing the jquery_ui but it was added in the related issue mentioned in the comment #6 Moving to RTBC.

  • DamienMcKenna authored 2417df28 on 8.x-3.x
    Issue #3330861 by DamienMcKenna: Fix composer validation errors
    
christianadamski’s picture

Status: Reviewed & tested by the community » Fixed

I was trying to figure out how to have tests run in D9 & D10.

Anyway, applied this.

Thanks!

christianadamski’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.