
Problem/Motivation
There are some problems with the composer.json file. When "composer validate" is executed it gives this error:
Root package 'drupal/geolocation' cannot require itself in its composer.json
This comes from the require-dev lines that are unnecessary IMHO.
Steps to reproduce
Run "composer validate" in the codebase.
Proposed resolution
Remove the "require-dev" items, they're unnecessary.
Remaining tasks
tbd
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#2 | geolocation-n3330861-2.patch | 467 bytes | damienmckenna |
Comments
Comment #2
damienmckennaAfter applying this patch the composer file validates correctly.
Comment #3
damienmckennaComment #5
elberI will work on it.
Comment #6
damienmckennaOther issues should be handled separately; see #3328967: New dependency jquery_ui_autocomplete is not automatically enabled for details.
Comment #7
damienmckennaComment #8
nick hope CreditAttribution: nick hope commentedIn case this saves someone else a few minutes of confusion... These require-dev lines are only in composer.json 8.x-3.x-dev. They are not in 8.x-3.11.
Comment #9
elberHi I aplied the patch and now composer.json is valid . I think the tests are breaking because is missing the jquery_ui but it was added in the related issue mentioned in the comment #6 Moving to RTBC.
Comment #11
christianadamski CreditAttribution: christianadamski commentedI was trying to figure out how to have tests run in D9 & D10.
Anyway, applied this.
Thanks!
Comment #12
christianadamski CreditAttribution: christianadamski commented