Please Release a Geocoder 7.x-1.3

I think #1914132: Entity property and #2159925: Geocode from virtual fields/entity property instead of just real fields try to solve (almost) the same thing: encode from a non-Field. Different approach. The boss should pick one.

@maintainers If we get this list cleaned up, do you feel confident to release another stable minor like 1.3?

I will publish a new release as soon as this list (or current Needs Review / RTBC issues) are cleaned up.

Removed duplicate entry

We're slowly getting there :-)

2 new important (related) bugs need fixing first though:

• #2649096: Fix exception throwing and empty result handling
• #2649086: Caching helper checks 'cache empty results' variable wrongly

Pol, could you choose which one to keep and mark the other one as duplicate?, because they have a combined fix for how errors and caching work (together). And maybe add it in this issue's body?

Hi,

I think the most important bug before the release is this one: #2649096: Fix exception throwing and empty result handling

After that, we're good for a release, I think.

I agree that's the issue, but the notice isn't the most important. And the other one has a ! wrong, so you have to fix that. I don't think we agree on the what-makes-an-error, so that's up yo you, but empty results should be cacheable, so fix the combination, not just the notice.

I will make a patch tomorrow for how I would see the error & caching as perfect. Up to you then what you use.

Maybe #1493496: When programmatically creating many nodes, 10k+ is there a way to skip geocoding if it has already been geocoded? is still important, even though it's 3y old. With the new 'caching instead of diffing' method, we (or I) kinda broke it for sites with many geocoded entities that update many at the same time. Since their cache is still empty, it'll lookup all of them at once, even though nothing's changed, to fill the cache. I didn't think about that. Relevant for many sites with programmatic updates.

We have to give some love to #1580512: Google geocoding with a Google business enterprise account and we're ready I think.

It's done, thank you all !!!

Awesome, Thanks!