When configuring the gelf module, check for the gelf-php library and set a message to notify the user if it is missing.

CommentFileSizeAuthor
#5 gelf-add_requirements_check-1398702-5.patch1.07 KBpdrake
#1 check_for_gelf_php_library-1398702-1.patch1.17 KBpdrake

Comments

pdrake’s picture

pdrake commented
StatusFileSize
new check_for_gelf_php_library-1398702-1.patch1.17 KB
jeffsheltren’s picture

jeffsheltren commented
Assigned: Unassigned » jeffsheltren
Status: Active » Needs review

Good idea, thanks for the patch.

jeffsheltren’s picture

jeffsheltren commented
Status: Needs review » Closed (fixed)

Thanks, pushed to 6.x-1.x-dev git

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Closed (fixed) » Needs work

Reopening this. IMO this should be in hook_requirements. At least once there is a stable release.

pdrake’s picture

pdrake commented
Status: Needs work » Needs review
StatusFileSize
new gelf-add_requirements_check-1398702-5.patch1.07 KB

Agreed. See attached.

jeffsheltren’s picture

jeffsheltren commented
Status: Needs review » Reviewed & tested by the community

Great, thanks. This works for me; committed to git.

I'm not sure what the standard convention is, but I've left the warnings in gelf.module in for now as well. Should we remove those now that we have a hook_requirements?

pdrake’s picture

pdrake commented

Not sure if there is a standard, but I have typically left such warnings in the configuration section as well as using hook_requirements.

pdrake’s picture

pdrake commented
Status: Reviewed & tested by the community » Fixed
jeffsheltren’s picture

jeffsheltren commented
Status: Fixed » Closed (fixed)

Closing