CommentFileSizeAuthor
#8 deprecated-code-report-3098708--13436483.patch7.22 KBsrvazquez
#4 3098708-4.patch10.7 KBshruthi_shetty
#2 3098708-1.patch11.11 KBshruthi_shetty

Comments

Shruthi Shetty M created an issue. See original summary.

shruthi_shetty’s picture

shruthi_shetty commented
Status: Active » Needs review
StatusFileSize
new 3098708-1.patch11.11 KB

Please review the patch.

james.williams’s picture

james.williams
Location Coventry, UK
commented
Status: Needs review » Needs work

I don't think this will be functional code? MessengerInterface::addMessage() cannot be called, as that's only the interface method. Have you tested this locally?

shruthi_shetty’s picture

shruthi_shetty commented
Status: Needs work » Needs review
StatusFileSize
new 3098708-4.patch10.7 KB

I have updated the changes please review the code.

james.williams’s picture

james.williams
Location Coventry, UK
commented
Status: Needs review » Needs work

There are other calls to method calls on an interface in this patch too. I can only presume it hasn't been tested locally. Until it has been, please keep the issue status as 'Needs work'.

srvazquez’s picture

srvazquez commented

I'm working on the deprecated functions.

srvazquez’s picture

srvazquez commented

Some of the deprecated functions have been removed.

srvazquez’s picture

srvazquez commented
StatusFileSize
new deprecated-code-report-3098708--13436483.patch7.22 KB

Some of the deprecated functions have been removed.

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Version: 8.x-2.x-dev » 3.0.x-dev
alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented

Is this ready to go back to Needs Review?

mrdalesmith’s picture

mrdalesmith commented
Status: Needs work » Closed (outdated)

I've closed this issue as all the fixes in the patch are currently in the 3.0.0-alpha5 release.