I'm having trouble getting FullCalendar to display at all on either IE 6 or IE 7 under Windows XP SP3. It works great on IE8, but only my list of nodes loads in IE7/6 - I get 'Done, but with errors on page.' after the page loads.
Does anyone else have this problem?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 1036444-11-fullcalendar-interdif.patch | 507 bytes | aspilicious |
| #3 | 980180-3.patch | 424 bytes | geerlingguy |
| #2 | ie7-error.png | 25.1 KB | geerlingguy |
Comments
Comment #1
geerlingguy commentedI'm getting a "Done, but with errors on page." Notice - and attached is the screenshot of IE's error report. I tried manually replacing the fullcalendar.js file with the latest (v1.4.9), but that didn't help either.
I did notice, when looking at the rendered page's source, that there's an odd whitespace difference for the 'timeFormat' line:
But I'm not sure if that would cause any problems with IE.
Comment #2
geerlingguy commentedThe error is attached here... oops.
Here's that block of HTML from the rendered page:
Comment #3
geerlingguy commentedLooking further into the issue, it looks like the comma on the last line is throwing IE6/7 for a loop - IE8, FireFox, Safari, Chrome, etc. etc. all ignore that comma, but IE 6 and IE 7 are completely stymied.
See for similar problem description: http://forumsblogswikis.com/2008/07/21/javascript-error-expected-identif...
I removed the trailing comma in views-view-fullcalendar.tpl.php, and the problem went away instantly (with both versions of fullcalendar.js.
Please see (and commit) the attached patch.
Comment #4
geerlingguy commentedComment #5
jwhat commentedI caught and fixed this in #906112: handle drag and drop: creating events, rescheduling events.
Comment #6
geerlingguy commentedI'd prefer this get fixed asap, though, as I'm sure many people will be turned off by the module not working in IE7 at all. It might be best to commit this tiny patch immediately, if possible, and then continue work on #906112: handle drag and drop: creating events, rescheduling events (best to keep issues focused on specific issues, imo).
Comment #7
tim.plunkettBug reports > feature requests.
Especially when it's a one character fix.
Comment #8
tim.plunketthttp://drupal.org/cvs?commit=456062
Comment #10
aspilicious commentedI think I broke IE7 again....
When I googled I found this...
So IE7 is broken in latest stable release.
Maybe you can apply this quickfix to all branches...
Don't look at the name of the patch....
Comment #11
aspilicious commentedComment #12
geerlingguy commentedYep.
Comment #13
tim.plunkettCommitted to all branches.
Let's not do this again, okay? :)
http://drupal.org/cvs?commit=488098
http://drupal.org/cvs?commit=488100
http://drupal.org/cvs?commit=488104