I'm having trouble getting FullCalendar to display at all on either IE 6 or IE 7 under Windows XP SP3. It works great on IE8, but only my list of nodes loads in IE7/6 - I get 'Done, but with errors on page.' after the page loads.

Does anyone else have this problem?

Comments

geerlingguy’s picture

I'm getting a "Done, but with errors on page." Notice - and attached is the screenshot of IE's error report. I tried manually replacing the fullcalendar.js file with the latest (v1.4.9), but that didn't help either.

I did notice, when looking at the rendered page's source, that there's an odd whitespace difference for the 'timeFormat' line:

          right: 'month agendaWeek agendaDay'
        },
                                        timeFormat: {
          agenda: 'h:mm{ - h:mm}'
        },

But I'm not sure if that would cause any problems with IE.

geerlingguy’s picture

StatusFileSize
new25.1 KB

The error is attached here... oops.

Line: 220
Char: 15
Error: Expected identifier, string or number
Code: 0

Here's that block of HTML from the rendered page:

          $('.fullcalendar_event').each(function() {
              event_details = $(this).find('.fullcalendar_event_details');
              events.push({
                  title: $(event_details).attr('title'),
                  start: $(event_details).attr('start'),
                  end: $(event_details).attr('end'),
                  url: $(event_details).attr('href'),
                  allDay: ($(event_details).attr('allDay') == '1'),
                  className: $(event_details).attr('cn'),
              }); <!-- this is line 220, the curly bracket is character 15... -->
          });
geerlingguy’s picture

Status: Active » Needs review
StatusFileSize
new424 bytes

Looking further into the issue, it looks like the comma on the last line is throwing IE6/7 for a loop - IE8, FireFox, Safari, Chrome, etc. etc. all ignore that comma, but IE 6 and IE 7 are completely stymied.

See for similar problem description: http://forumsblogswikis.com/2008/07/21/javascript-error-expected-identif...

I removed the trailing comma in views-view-fullcalendar.tpl.php, and the problem went away instantly (with both versions of fullcalendar.js.

Please see (and commit) the attached patch.

geerlingguy’s picture

Title: Internet Explorer 6/7 Compatibility? » Extra trailing comma breaks Fullcalendar in IE 7 & IE 6
jwhat’s picture

geerlingguy’s picture

I'd prefer this get fixed asap, though, as I'm sure many people will be turned off by the module not working in IE7 at all. It might be best to commit this tiny patch immediately, if possible, and then continue work on #906112: handle drag and drop: creating events, rescheduling events (best to keep issues focused on specific issues, imo).

tim.plunkett’s picture

Version: 6.x-1.2-beta5 » 6.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Bug reports > feature requests.
Especially when it's a one character fix.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aspilicious’s picture

Title: Extra trailing comma breaks Fullcalendar in IE 7 & IE 6 » Extra trailing comma breaks Fullcalendar in IE 7 & IE 6 [BROKEN AGAIN]
Priority: Normal » Critical
Status: Closed (fixed) » Active
StatusFileSize
new507 bytes

I think I broke IE7 again....
When I googled I found this...

So IE7 is broken in latest stable release.
Maybe you can apply this quickfix to all branches...

Don't look at the name of the patch....

aspilicious’s picture

Status: Active » Needs review
geerlingguy’s picture

Status: Needs review » Reviewed & tested by the community

Yep.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.