Some people are confused by the options we give when we add a fullcalendar row style.
I made a patch to disabled some checkboxes when needed and added some clarification.
First I thought to make them #hidden but an empty fieldset looks kinda weird...
Maybe we could make them hidden but change the message on top a bit.
Dunno needs review, feel free to help :)
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fullcalendar-1057156-4.patch | 1.36 KB | tim.plunkett |
| #3 | fullcalendar-1057156-3.patch | 1.81 KB | tim.plunkett |
| #2 | fullcalendar-1057156-2.patch | 1.07 KB | aspilicious |
| fullcalendar-make things-clear.patch | 1.23 KB | aspilicious |
Comments
Comment #1
aspilicious commentedComment #2
aspilicious commentedThis patch uses the hidden approach, I think it's better.
Comment #3
tim.plunkettI love this idea, but when I create a new view and try to save the Row Style before adding fields, I get:
An illegal choice has been detected. Please contact the site administrator.
An illegal choice has been detected. Please contact the site administrator.
An illegal choice has been detected. Please contact the site administrator.
So, I combined the two patches, and it worked great. :) Can you double check this?
Comment #4
tim.plunkettThat was a rather heavy handed approach.
The checkboxes need to be hidden, the selects need to be disabled.
Comment #5
aspilicious commentedI noticed the ajax errors but I didn't care at that moment ;).
This works great :).
I love these small usability improvements. :)
Comment #6
tim.plunketthttp://drupal.org/cvs?commit=497862