Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 12.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Issue fork freelinking-3598482
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.
Currently Drupal Rector, version dev-main, cannot fix all Drupal 12 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 12 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #6
mradcliffeYep, Drupal 10 and Drupal 12 are incompatible for phpunit changes so I'm going to have to branch 5.0.x.
Comment #7
mradcliffeComment #8
mradcliffeComment #9
mradcliffeJust one test failure on Drupal 12.
The phpstan issues are not relevant yet, but code quality tests are working again.
I'm going to close the automated merge request because it wasn't as helpful for this module other than uncovering not being able to support 10 and 12 together.
Comment #11
mradcliffeMore hidden BC breaks.
It looks like 11.3 will not be compatible with 11.4 due to the removal of long tips, and there's no way to support advanced_help and advanced_help_hint anymore via lenient so those are removed in favor of help topics.
Comment #12
mradcliffeThe phpstan warning about `tips` covariance is a false negative because the module now depends on 11.4, but the tests still use 11.3.
I will need to wait until 11.4.0 is officially released until this module can be compatible with 12.0.0.
Comment #13
mradcliffeGitLab CI is updated to test on 11.4 now.
Comment #14
mradcliffeAaaaaaand, Drupal 12 requires guzzle 8 but Drupal 11 requires guzzle 7 and these are not backwards-compatible.
So Drupal 11 and Drupal 12 are not backwards-compatible.
I'll need to revoke Drupal 11 support.
Comment #15
mradcliffeNo way to make GitLab CI pipeline happy until merge, but the Drupal 12 tests are passing now.
Comment #19
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.
Currently Drupal Rector, version 1.1.2, cannot fix all Drupal 12 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 12 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #22
mradcliffeProject update bot picked up some missing PHPUnit group annotation to attribute fixes.