In testing freelinking 4.6 on drupal 4.5, see conversation here, I ran into an error on PostgreSQL.

user error: query: SELECT nid FROM node n WHERE title ="Some node" in includes/database.pgsql.inc on line 121.

warning: Cannot modify header information - headers already sent by (output started at includes/common.inc:344) in includes/common.inc on line 155.

Postgres doesn't appear like queries with double quotes, only single.

Patch attached.

Did not test patch against MySQL, but did test the single quote query syntax on MySQL and it worked fine. So this patch should be considered a general compatability fix.

CommentFileSizeAuthor
freelinking.module-pgsql_query.patch816 byteshystrix

Comments

eafarris’s picture

eafarris commented
Assigned: Unassigned » eafarris

Applied to DRUPAL-4.6 and HEAD. Thanks, hystrix! Please verify and close.

hystrix’s picture

hystrix commented

Tested. Works on 4.5.0 against psql. Closing issue.

Probably safe to release a 4.5.0 version of your module.

eafarris’s picture

eafarris commented

Branched the existing DRUPAL-4-6 version to DRUPAL-4-5. On the next project regen on Drupal.org it should show up in the contributions repository for 4.5.x. Many thanks for your work on this.