I just upgraded FPA to 7.x-2.4, and almost immediately got a warning:

Strict warning: Only variables should be passed by reference in theme_fpa_user_admin_permissions() (line 123 of /home/nj8j/public_html/sites/all/modules/fpa/fpa.theme.inc).

This is the problem line:

$first_permission_index = array_shift(element_children($form['checkboxes']));

The problem appears to be that we're passing array_shift the return from element_children instead of an actual array variable.

Easiest way to fix this is to put the element_children return in a variable, and pass the variable.

Patch attached.

CommentFileSizeAuthor
fpa-Fix_reference_warning.patch782 bytesben coleman

Comments

  • Commit fafc83e on 7.x-2.x authored by Ben Coleman, committed by corey.aufang:
    Issue #2249041 by bcoleman, corey.aufang: Correct warning about pass by...
corey.aufang’s picture

Status: Needs review » Fixed

You see nothing....

ben coleman’s picture

~Sargeant Shultz voice~ I see nothing! nothing!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.