CommentFileSizeAuthor
#5 replace_t-2765433-4.patch967 bytesShreya Shetty
#2 replace_t-2765433-2.patch686 bytesShreya Shetty
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shreya Shetty created an issue. See original summary.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Active » Needs review
FileSize
replace_t-2765433-2.patch686 bytes

Status: Needs review » Needs work

The last submitted patch, 2: replace_t-2765433-2.patch, failed testing.

BTMash’s picture

BTMash CreditAttribution: BTMash as a volunteer commented
Status: Needs work » Closed (won't fix)

Unfortunately, static functions do not have a concept of $this so I cannot accept the patch.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
FileSize
replace_t-2765433-4.patch967 bytes

Yes we can use the class directly provided the patch for the same

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Closed (won't fix) » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: replace_t-2765433-4.patch, failed testing.

BTMash’s picture

BTMash CreditAttribution: BTMash as a volunteer commented

Hmm, thanks for this. I'll try it out locally and see how it goes.

BTMash’s picture

BTMash CreditAttribution: BTMash as a volunteer commented
Status: Needs work » Needs review

BTMash’s picture

BTMash CreditAttribution: BTMash as a volunteer commented
Status: Needs review » Fixed

@Shreya, thanks for this. Verified that this works and the tests pass.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.