It is needed to play videos inside Colorbox. Enabling it on install of the Flickr module would save the site builder having to do it manually and some people don't read README files.

CommentFileSizeAuthor
#4 conditionally_enable_colorbox_inline-2367355-4.patch886 byteslolandese
#3 conditionally_enable_colorbox_inline-2367355-3.patch696 byteslolandese
#1 conditionally_enable_colorbox_inline-2367355-1.patch692 byteslolandese

Comments

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new conditionally_enable_colorbox_inline-2367355-1.patch692 bytes
lolandese’s picture

lolandese commented
Status: Needs review » Needs work

PHP Parse error: syntax error, unexpected T_STRING, expecting '(' in /home/martin/www/orange/sites/all/modules/flickr/flickr.install on line 11

lolandese’s picture

lolandese commented
Status: Needs work » Needs review
StatusFileSize
new conditionally_enable_colorbox_inline-2367355-3.patch696 bytes
lolandese’s picture

lolandese commented
StatusFileSize
new conditionally_enable_colorbox_inline-2367355-4.patch886 bytes

We could as well conditionally set the other variables needed to make Colorbox working out-of-the-box.

Just to make installation a bit more user friendly. Besides variable_set('colorbox_inline', 1); added both in the install and update hooks:

    variable_set('flickr_class', 'colorbox');
    variable_set('flickr_rel', 'gallery-all');

Maybe we should add a note to the installation instructions to enable Colorbox before installing the Flickr module.

  • lolandese committed 95c84cb on 7.x-1.x 
    Issue #2367355 by lolandese: Enable Colorbox inline on install/update if...
lolandese’s picture

lolandese commented
Status: Needs review » Fixed

Tested both a clean install and an update from 7.x-1.6. All fine as expected.

  • lolandese committed 1637095 on 7.x-1.x 
    Issue #2367355 by lolandese: Some additional README text.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.