Closed (fixed)
Project:
Field Slideshow
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
13 Nov 2019 at 19:07 UTC
Updated:
26 Dec 2019 at 18:59 UTC
Jump to comment: Most recent
Comments
Comment #2
aubjr_drupal commented@vuil - I don't see the issue in the queue (unpublished?) Do you know which version or branch has the actual issue? 7.x or 8.x, etc? If it's 7.x, I can help out as well.
Comment #3
lamp5Hi. I am a maintainer of the 8.3-x branch. If you have any problem, please open an issue queue or provide a patch. It will be quickly reviewed and committed because we still using this module.
Comment #4
stefan.korn@lamp5: Are you sure you are a maintainer of this module? You are not listed, actually there are no maintainers listed.
The module was made unsupported by the Drupal Security Team yesterday.
If the security issue can be disclosed I would try to fix it.
Comment #5
stefan.kornComment #6
lamp5Yes, I am sure because I am a author of branch 8.3-x which support cylce2 plugin. Security issue do not concerns 8.x version. Instead of mark whole project like unsupported, security team could marked only 7.x version.
Comment #7
stefan.kornThen maybe can you make me a co-maintainer, so I could have a look in the D7 security issue and maybe fix it?
Comment #8
quantos commentedFollowing. Not a programmer but I use this module quite extensively. It's a fairly 'cornerstone' module for lots of design/builds but let me know if there's anything I can do to help review/test updates, etc. Seems nuts the 7.x version has somehow fallen through the cracks and found itself in 'disrepair' like this.
Q.
Comment #9
m_z commented@lamp5 : +1 for making @stefan.korn a co-maintainer to fix the D7 security issue (I worked together with him in the past and he is an experienced developer
modules with such a big usage like field_slideshow shouldn't be marked as "unsupported"...
Comment #10
lamp5@stefan.korn you have to contact with the security team. Right now I (co-maintainer) have no permissions to grant access to you.
Comment #11
bart lambert commentedI'm no programmer but an extensive user of this module on drupal7 & 8. Hope somebody can/will fix this security problem very soon!
on my newest site:
Not supported! Error
Field Slideshow 8.x-3.0-beta1
Project not supported: This project is no longer supported, and is no longer available for download. Disabling everything included by this project is strongly recommended!
Includes: Field Slideshow
Comment #12
lamp5I provided a patch, it waiting for the review by the security team. Have hope, it will be quickly fixed and a module back to live.
Comment #13
quantos commentedWell done lamp5.
*pat on the back*
Much appreciated.
Q.
Comment #14
vuilSounds good!
Comment #15
criscomGreat job, lamp5. Thanks.
Comment #16
Esteban75012 commentedDo you know the average delay to have an answer from the security team ? I hope the patch will resolve the problem...
Comment #17
iioannou commentedThank you lamp5 for providing a fix for the module. Does anyone know when the updated version will be available ? Also is there a quick way to patch our sites prior to waiting until this is approved ?
Comment #18
jonaskills commentedFollowing. Where can we get the patch until it is approved?
Thanks!
Comment #19
lamp5Relax guys, this issue is not dangerous for yours sites, nobody can't attack you. Now we are waiting for patch review but no other maintainers are active. Cheers
Comment #20
robbdavis commentedHey @lamp5. Thanks so much for submitting the patch. Is there any way we can see that code? Or, how do we find out exactly what the security issue is? You seem to be saying that it's not too serious and the module, as is, isn't a big threat.
Comment #21
robbdavis commentedHey, further to this, the security advisory on the front page says: "File an issue in the queue with a patch to fix the module and then contact the security team"
So @lamp5. It sounds like the correct process to get this fixed is to put your patch in the issue queue. Can you please add it there so we can all take a look?
Comment #22
leducdubleuet commented@robbdavis You should check this recent discussion on the subject in another module : https://www.drupal.org/project/admin_views/issues/3094272#comment-13353994
I think it helps to understand the process or at least, to better understand the intentions behind the secretiveness...
Comment #23
jbenjamin commentedDo we have any timeline on this module being re-instated? I'm getting dozens of update emails, and I'd love to move on to the next thing to worry about :)
thanks!
Comment #24
lamp5Field slideshow is now alive, get involved to avoid similar situations in the future.
Comment #25
quantos commentedWell done lamp. thank you.
Comment #26
bart lambert commentedLamp5, thank you for reanimating this module!!!!! You are the best!!!!!