Problem/Motivation

This module has a views component at src/Entity/FeedbackMessageViewsData.php that doesn't currently have tests. We should add tests.

(note this ticket is split from #3480990: Add automated tests)

Proposed resolution

Figure out how to test the views component, then write one.

This will probably involve creating a test module with a view in config/install.

Remaining tasks

  1. Write a patch - merge request !15 created by @mparker17 in #3
  2. Community/maintainer - skipped by @mparker17 in #4
  3. Commit - merged by @mparker17 in #5
  4. Release

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork feedback-3481798

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3481798-add-views-test Comparechanges, plain diff MR !15
    • 1 hidden branch
  • 3.x Comparecompare
About issue forks

Comments

mparker17 created an issue. See original summary.

mparker17 changed the visibility of the branch 3.x to hidden.

mparker17 opened merge request !15

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

Created merge request !15. Going to skip the community review because testbot is happy with it, it was written by a maintainer, and it only changes non-production code. Merging shortly.

  • mparker17 committed c3f1e988 on 3.x 
    feat: #3481798 Add tests for views component

By: mparker17
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Merged. I will update this issue when this code is released.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.