Thanks for this great module!

I ran into an issue with ECK module and the fc + fc_incomplete modules enabled.

In rc2 version of this module with ECK set up, trying to include the block in a region and then navigating to the entity's view page results is the following error:

Call to undefined method stdClass::entityType() in {...}/sites/all/modules/eck/eck.module on line 159

I traced the issue down the ECK requiring a bundle for it's URI callback. The function fc_get_page_entity() calls the entity's uri callback which fails as per the error above due to it lacking a bundle to run on the passed in "dummy" values.

I've also found that the fc_progress submodule suffers a similar fate in that the ECK entity I had to hand didn't appear to have a label callback.

Patch to follow with both of these issues remedied with hopefully no adverse effects on the existing functionality. I also tried setting up a node with incomplete fields just to check I hadn't broken anything- and everything looks ok from here.

Hopefully this helps other people running into similar issues with ECK. This is obviously the first pass at this and will still need some review by others. If anything else comes up in our testing, I'll report back here.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Barry_Fisher’s picture

Here's the patch.