Currently the general dynamic like button renders in the primary content block (with position options). This makes it impossible to put the like button underneath other blocks in the content region.
I would like to see that the dynamic like button renders in a block. So that I can position it easier.

CommentFileSizeAuthor
#16 fblikebuttondisplays-1167194-16.patch29.54 KBdmsmidt
#4 fblikebuttonblocks-1167194-4.patch26.45 KBdmsmidt

Comments

jerdiggity’s picture

jerdiggity commented
Assigned: Unassigned » jerdiggity
Status: Active » Closed (won't fix)

That was my initial idea as well. However the problem with that (correct me if I'm mistaken) is in situations like the front page, or any page within which multiple nodes are displayed. For example, if there were 4 teasers being displayed on a particular page, and the button was in a block, you'd end up with something like 4 buttons piled directly on top of each other with each displaying the same verbiage and the ultimate result would not only be aesthetically unappealing, but also it would make things pretty tough on any of your users to differentiate between which button linked to which node.

Thanks for the suggestion -- much appreciated. However as far as I can tell, it just doesn't seem feasible at this point (and like I said, that was my original thought too). :)

jeremy

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

Thanks for your clear explanation. I understand the use case your pointing out, however a lot of pages are build up from blocks, displaying only on certain pages etc. The current state of the module only allows us to arrange it in a small part of the page (the node content area block).

Maybe we can enhance the module to let the user chose from displaying in the content block or a separate block. And maybe even a different setting for teasers (and even further, more flexible views compatibility).

I've patched my version of this module to display in a block for now.

jerdiggity’s picture

jerdiggity commented
Status: Closed (won't fix) » Active

Aside from ensuring that security standards are #1 on the list of priorities, my only concern is to implement whatever it is that everyone else (other than me) wants.
With that said...

Maybe we can enhance the module to let the user chose from displaying in the content block or a separate block. And maybe even a different setting for teasers (and even further, more flexible views compatibility).

I've patched my version of this module to display in a block for now.

... sounds like a good idea to me. Would you mind sharing the patch? If so (and if it checks out, of course) I'd be more than happy to roll it in one of the next releases.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented
StatusFileSize
new fblikebuttonblocks-1167194-4.patch26.45 KB

Here we go.

I made a lot of changes:

  • Names: because the twofold nature of the module, I changed the names of the two functions to: Dynamic Like button and Static Like button. They were called: General and Block. This because of the new possibility to display the "general" FB Like button also as a block. The big difference is the static/dynamic nature of the button.
  • In order to make the twofold nature clear to the user I modified the config pages, added descriptions and some reorganization of fieldsets.
  • Removed the settings on the block page, this is duplicate functionability, which can confuse the user. I added a link to the config page instead.
  • And the rest of the code to make it work ^_^

This is my first patch on a module, so bear with me.
No real support to like a page created by a view yet.
Upgrading seems to have no problems, all settings are kept.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented
Status: Active » Needs review

Too bad I don't get any feedback..

Anonymous’s picture

Anonymous (not verified) commented

Very good

but :-)

one error

Notice: Undefined index: language em _fblikebutton_field() (linha 244 de /home2/raduungu/public_html/cp/sites/all/modules/fblikebutton/fblikebutton.module).

Best regards
ArchGalileu

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

This was made before the language stuff was fixed. If wanted I can do something about it, but I want the support of the maintainer first, before going away from the core too far.

Anonymous’s picture

Anonymous (not verified) commented

Ok

Waiting :-)

Best regards
ArchGalileu

skizzo’s picture

skizzo commented

Could the above patch be backported to D6 ?

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

First I would like to see this committed to the 7.x-dev branch, (patch would need some rework to work with the latest changes), later we can think about further steps.. (extra options/backports)

theullrich’s picture

theullrich commented

sub

theullrich’s picture

theullrich commented
Status: Needs review » Needs work

Haveing problem with installing the patch. Worked before? not matching up in multiple places anymore.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

#12 thats correct, see my comment in #10
I've had no word from the maintainer, even sent him a mail..

theullrich’s picture

theullrich commented

well he has not done anything on his site since July and nothing on drupal since before then. So it may be a while. I would really like to use this though. Can I convince you to update your patch anyway?

Allan Walker’s picture

Allan Walker commented

subscribing

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented
Title: Positioning the general like button as block » Positioning the general like button as block or in the link area
Version: 7.x-1.1 » 7.x-1.x-dev
Assigned: jerdiggity » dmsmidt
Status: Needs work » Needs review
StatusFileSize
new fblikebuttondisplays-1167194-16.patch29.54 KB

Hi there everybody,

Good news I upgraded the patch, cleaned some code and added an extra function.
The patch works with the latest dev version (2011-Jun-13).
This includes some fixes of jerdiggity him self (for example the language option).

- I introduced the option to display the FB like button in his own block earlier (instead of the content area).
- Now I added the option to display the button in the link area (as requested here: http://drupal.org/node/1171922).

In #4 I explained more changes.

Please test it.

I hope you like it and that it will get committed some time..

maerys’s picture

maerys commented
Priority: Normal » Minor
Status: Needs review » Fixed

thank you so much! this works like a charme (so far). even with page manager / panels.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

As requested I also created a Drupal 6 patch. It's a complete new backport of my D7 version.
See: http://drupal.org/node/1171922#comment-5020346

theullrich’s picture

theullrich commented

the dynamic block does not appear on my install. The old block disappears but only the static one shows up. I have done the update twice both times no errors just dynamic does not show up.

theullrich’s picture

theullrich commented

I found out that I had to go into settings and activate it.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

Good that you found out on your own. It is indeed not automatic, since there are multiple view modes, and the block is only one of them. Can you give feedback on this version?

samhassell’s picture

samhassell commented

Cool patch, seems to work for me.

theullrich’s picture

theullrich commented

Ok now that I have used this for a while here is my review. It works great. Have not seen any errors. Everything is well labeled and easy to use. I have had not problems with displaying. Works great. Good Patch

samhassell’s picture

samhassell commented
Status: Fixed » Reviewed & tested by the community
dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented

So: fixed a couple of issues, added new functions, cleaned up code, made the UX better and ported it all back to D6. Both versions tested and reviewed by the community. What now? Would be nice to have it committed. The maintainer however doesn't respond in the issue queue and mails I sent.

summit’s picture

summit commented

Hi, would love to see D6 and D7 committed also?
May be you could ask co-maintainership?
Greetings, Martijn

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented
Version: 7.x-1.x-dev » 7.x-2.0
Status: Reviewed & tested by the community » Fixed

Today I released a new version of the module (as co-maintainer now), incorporating all the new functions mentioned here. D7 and D6 as well.

Marking this issue Fixed.

tuwebo’s picture

tuwebo commented

The very first test with this new release 7.x-2.0 and panels seems to work for me.
Awesome work!!
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.