Closed (fixed)
Project:
Frequently Asked Questions
Version:
5.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Oct 2008 at 19:53 UTC
Updated:
5 Jan 2009 at 22:36 UTC
Hello,
If the FAQ module is enable with the faq_use_categories option set drupal will make one call to the database for each comment. This is very bad for big sites.
If I'm not missing something the solution is easy, you just have to add another condition on line #1969 of faq.module.
From:
function faq_link_alter(&$node, &$links) {
if (!variable_get('faq_use_categories', FALSE) || !module_exists("taxonomy")) {
return;
}
To:
function faq_link_alter(&$node, &$links) {
if (!variable_get('faq_use_categories', FALSE) || !module_exists("taxonomy") || $node->type != 'faq') {
return;
}
Thanks,
introfini
Comments
Comment #1
stella commentedThanks! Patch committed for both Drupal 5 and Drupal 6 versions. Will be included in the next dev release, available in the next few hours.
Cheers,
Stella
Comment #2
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #3
stella commentedReleased in 5.x-2.12 and 6.x-1.8.