Problem/Motivation

The facet source is currently only displayed on the facets overview page. For developer convenience, it would be nice to have the source displayed on the facet's edit form.

Proposed resolution

Display the facet's source on the facet edit form.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The facet's source is displayed on the facet edit form

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#8 facets-display_source-2937294-8.patch4.6 KBidebr
#8 interdiff-4-8.txt701 bytesidebr
#4 facet-source.png40.86 KBidebr
#4 facets-display_source-2937294-4.patch4.61 KBidebr
#4 interdiff-3-4.txt2.35 KBidebr
#3 2937294.patch3.6 KBborisson_

Comments

idebr created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +Needs tests

I agree, this is a good idea. Let's do this!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2937294.patch3.6 KB

I guess this is good place to start, this could use more styling / better markup though.

idebr’s picture

idebr commented
Issue summary: View changes
StatusFileSize
new interdiff-3-4.txt2.35 KB
new facets-display_source-2937294-4.patch4.61 KB
new facet-source.png40.86 KB

I agree, great start!

I suggest we use the default #type => item styling available in Seven:

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looks solid, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: facets-display_source-2937294-4.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Looks like I was too trigger-happy with that rtbc, the newly added test is too brittle. It shouldn't find the entire string, just the facet source is sufficient.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-4-8.txt701 bytes
new facets-display_source-2937294-8.patch4.6 KB

Updated Drupal\Tests\facets\Functional\IntegrationTest to scan for the Facet source label only

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Test is green, thanks!

  • StryKaizer committed 6176adf on 8.x-1.x authored by idebr 
    Issue #2937294 by idebr, borisson_: Display the facet's source on the...
idebr’s picture

idebr commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.