Once #2856050: Use base path instead of url object in the DisplayInterface is in, we should revert the getPath function on facet sources to return a base path again.

CommentFileSizeAuthor
#9 use_base_path_instead-2856067-9.patch5.13 KBgnuget
#6 use_base_path_instead-2856067-6.patch6.26 KBstrykaizer
#2 break_all_tests.patch5.42 KBstrykaizer

Comments

StryKaizer created an issue. See original summary.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Active » Needs review
StatusFileSize
new break_all_tests.patch5.42 KB
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Parent issue: » #2856050: Use base path instead of url object in the DisplayInterface

Status: Needs review » Needs work

The last submitted patch, 2: break_all_tests.patch, failed testing.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented

Note, as long as #2856050: Use base path instead of url object in the DisplayInterface is not in latest search api tag, tests in this issue will not be green.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new use_base_path_instead-2856067-6.patch6.26 KB

Should be green once #5 is fixed

Status: Needs review » Needs work

The last submitted patch, 6: use_base_path_instead-2856067-6.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Postponed
Issue tags: +dcnlights

We discussed this at dcnlights. I agree with the approach taken here. Setting this issue to postponed for now, until we get the search api issue in.

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new use_base_path_instead-2856067-9.patch5.13 KB

Hi.

This patch not longer applies since #2840140: Cleanup dummy query url processor. was committed.

So I did a quick reroll of #6.

Regards.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Postponed » Needs review

Let's see if the patch still applies and passes now.

Status: Needs review » Needs work

The last submitted patch, 9: use_base_path_instead-2856067-9.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Fixed

Committed and pushed, thanks!

  • borisson_ committed bd717bd on 8.x-1.x authored by StryKaizer 
    Issue #2856067 by StryKaizer, gnuget: Use base path instead of url...
gnuget’s picture

gnuget
Primary language Spanish
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.