We've needed a file example for some time.

So far this one demonstrates the key D7 APIs.

Next step is to demonstrate a custom streamwrapper.

CommentFileSizeAuthor
#5 examples.file_example_874364_05.patch44.65 KBrfay
#2 examples.file_example_874364_02.patch30.76 KBrfay
examples.file_example_initial.patch7.72 KBrfay

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Component: Other » File Example
Status: Active » Needs review

Would appreciate review by anyone and everyone.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new examples.file_example_874364_02.patch30.76 KB

This patch extends the above example by adding support for a session:// scheme, where "files" are written to a subkey of the $_SESSION variable. It provides a nearly complete read/write stream wrapper example.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented

subscribe, will try and review later

dman’s picture

dman commented

Thanks for this. I don't understand it all yet, but it's good to know that docs are there.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new examples.file_example_874364_05.patch44.65 KB

OK, now with significant tests and a pretty exhaustive streams demo implementation.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to CVS HEAD
http://drupal.org/cvs?commit=405304

Review is still welcomed!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Fixed » Needs work

For some reason, despite the fact that the commit shows, this isn't in the release package, and it's also not being tested.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review

#5: examples.file_example_874364_05.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, examples.file_example_874364_05.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Fixed

Tests are running and passing now.

bicherele’s picture

bicherele commented
Status: Fixed » Needs review

#5: examples.file_example_874364_05.patch queued for re-testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

@bicherele, this has already been committed. See #6. Your review is still appreciated though.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.