Coder and tests pass. As I guess we don't want to test PHP, I've removed some methods and documented the rest. This module has no Drupal API, just hook_xmlrpc, so for development and documentation purposes there is no need to maintain 8 methods, and I left only 3. Hope you don't mind with this (not Drupal related) change.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | examples.xmlrpc_d7.patch | 9.98 KB | rfay |
| #1 | xmlrpc_example_617852_01.patch | 7.24 KB | rfay |
| xmlrpc_example_drupal_7_ilo.patch | 7.67 KB | ilo |
Comments
Comment #1
rfayThanks for doing this. It passes the tests, but unfortunately I know nothing about xmlrpc and cannot make head nor tail of how one would test this module. So IMO we need to add some explanatory material to the .module file. I know the English comments are not your strong point, so will be happy to help with this if you'll explain it to me.
Attaching the slightly changed patch.
Comment #2
rfayThanks @ilo for working with me on this tonight. You made it perfectly clear.
I think I'll try to extend it as a deliberate example of both client and server, as you suggested. and explain as I go along what it's about.
Comment #3
rfayHere is a rewrite, trying to use a very simple addition/subtraction example. It shows both the server end and the client end.
Comment #4
rfayPassed the bot, so committing. Comments, concerns, and patches are welcome.
http://drupal.org/cvs?commit=327076
@ilo: Thanks for your patience with me on this one, thanks for all your work on it, and I hope you like the result.
Comment #5
ilo commented+ return xmlrpc_error(10001, t("Sorry, I only have ten fingers and can't count past that."));
LOL! understanding Drupal limits++
Comment #6
rfay