Coder and tests pass. As I guess we don't want to test PHP, I've removed some methods and documented the rest. This module has no Drupal API, just hook_xmlrpc, so for development and documentation purposes there is no need to maintain 8 methods, and I left only 3. Hope you don't mind with this (not Drupal related) change.

Comments

rfay’s picture

Status: Needs review » Needs work
StatusFileSize
new7.24 KB

Thanks for doing this. It passes the tests, but unfortunately I know nothing about xmlrpc and cannot make head nor tail of how one would test this module. So IMO we need to add some explanatory material to the .module file. I know the English comments are not your strong point, so will be happy to help with this if you'll explain it to me.

Attaching the slightly changed patch.

rfay’s picture

Thanks @ilo for working with me on this tonight. You made it perfectly clear.

I think I'll try to extend it as a deliberate example of both client and server, as you suggested. and explain as I go along what it's about.

rfay’s picture

Status: Needs work » Needs review
StatusFileSize
new9.98 KB

Here is a rewrite, trying to use a very simple addition/subtraction example. It shows both the server end and the client end.

rfay’s picture

Title: update xmlrpc_example module to Drupal 7 » update XML-RPC Example module to Drupal 7
Status: Needs review » Fixed

Passed the bot, so committing. Comments, concerns, and patches are welcome.
http://drupal.org/cvs?commit=327076

@ilo: Thanks for your patience with me on this one, thanks for all your work on it, and I hope you like the result.

ilo’s picture

Component: Code » AJAX Example

+ return xmlrpc_error(10001, t("Sorry, I only have ten fingers and can't count past that."));

LOL! understanding Drupal limits++

rfay’s picture

Component: AJAX Example » XMLRPC Example

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.