Over in https://www.drupal.org/node/2340197#comment-9156763

There has been an avalanche of unrelated errors such as

Argument 1 passed to Drupal\Core\Access\AccessResult::orIf() must implement interface Drupal\Core\Access\AccessResultInterface, boolean given, called in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Entity/EntityAccessControlHandler.php on line 237 and defined

The cause #2287071: Add cacheability metadata to access checks

Access needs to be refactored in light of this change. It is a blocking issue, so I am marking this as critical.

Comments

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Martin, are you taking this on?

martin107’s picture

martin107 commented

The amount of time I have for open source varies, depending on how much other work I have on at the moment ... please feel free to jump on it,
otherwise I will give it some effort early need week ... I think..

martin107’s picture

martin107 commented

Just a quick note.

Over on github ... the socketwench's flag module has a issue raised about this subject

https://github.com/socketwench/flag-drupal8/issues/67

Berdir - say he is currently activley working on it... his changes when complete may provide a template for us...

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Looks like this is the real change notice: https://www.drupal.org/node/2337377

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Active » Fixed

It's not really a refactor that's necessary. Just change some return values: http://cgit.drupalcode.org/examples/commit/?h=8.x-1.x&id=0dec6ade63bc139...

This will definitely need some explanation in various permissions-based examples as we port them to D8.

Also I added this comment to the change notice: https://www.drupal.org/node/2337377#comment-9160637

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.