I have just run example through PHPStorm's inspection tool ( a lint checker )

and found a couple of easy to fix nit-picks where the annotations don't use full-qualifed-domain names.
or document what exceptions are thrown in the in annotations.

Most of the errors exist in the config_entity_example area but not exclusively.

I hope this is quick to review...

CommentFileSizeAuthor
fqdn-0.patch4.58 KBmartin107

Comments

martin107’s picture

martin107 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, fqdn-0.patch, failed testing.

martin107’s picture

martin107 commented

The failure here are nothing to do with the patch

They are caused now that Issue #2287071: Add cacheability metadata to access checks has landed.

Argument 1 passed to Drupal\Core\Access\AccessResult::orIf() must implement interface Drupal\Core\Access\AccessResultInterface, boolean given, called in

I am about to file a new issue for that!

martin107’s picture

martin107 commented
Related issues: +#2340213: Refactor Access mechanism

Ok issue created

#2340213: Refactor Access mechanism

martin107’s picture

martin107 commented
Status: Needs work » Needs review

Now that @Mile23 has fix the blocking critical, this needs a retest.

Miles23++

Mile23 queued fqdn-0.patch for re-testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Easiest just to click on 'retest.'

Mile23 queued fqdn-0.patch for re-testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Fixed

And committed.

Thanks, Martin.

  • Mile23 committed 4e3b344 on 8.x-1.x authored by martin107 
    Issue #2340197 by martin107: A couple of lint failures.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.