The following tests failed:

DBTNGExampleTest
SimpleTestExampleMockModuleTest

Here's a failing test: https://qa.drupal.org/pifr/test/785538

CommentFileSizeAuthor
#5 2262989_5.patch6.66 KBmile23
#5 interdiff.txt899 bytesmile23
#2 2262989_dbtng_only.patch5.78 KBmile23

Comments

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Assigned: Unassigned » mile23
Issue summary: View changes

Working on the branch issues.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Test SimpleTestExampleMockModuleTest and DBTNGExampleTest failing » Branch fail: SimpleTestExampleMockModuleTest and DBTNGExampleTest failing
StatusFileSize
new 2262989_dbtng_only.patch5.78 KB

This should fix the DBTNG problems. More later today.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2262989_dbtng_only.patch, failed testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
StatusFileSize
new interdiff.txt899 bytes
new 2262989_5.patch6.66 KB

Interdiff shows changes to simpletest.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Needs review
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work

Due to this: https://drupal.org/node/2250345

...we also need to change over the hook_help() implementation for both modules.

  • Commit 036c5df on 8.x-1.x by Mile23: 
    Issue #2262989 by Mile23 | cgalli: Branch fail:...
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Fixed

Added changes to hook_help(), and....

Committed. http://drupalcode.org/project/examples.git/commitdiff/036c5df3c0579dd451...

Thanks, @cgalli!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.