According to the latest D7 RC3 announcement we only have to include files[] = xxx in the .info file if it contains at least one class or interface.

Comments

aspilicious’s picture

Status: Active » Needs review

- examples still seem to work :)

Status: Needs review » Needs work

The last submitted patch, remove_cruft_from_info_examples.patch, failed testing.

rfay’s picture

Title: Remove curft from .info file » Remove unnecessary files[] declarations from .info file
Status: Needs work » Needs review
StatusFileSize
new9.73 KB

I don't know why that failed. Here's the same thing again, created by applying that one and then editing the vertical_tabs.info.

If we can't figure this out, we'll skip vertical_tabs and get the result to pass, then edit and commit vertical_tabs. I had to do that before with a .info file patch that acted like this.

Status: Needs review » Needs work

The last submitted patch, examples.info_files_1007580_02.patch, failed testing.

rfay’s picture

I see nothing wrong with this, so I'm going to commit it and then we'll work from there.

Committed: http://drupal.org/cvs?commit=469672

And I note that I had no trouble patching in CVS.

Now we just see how the post-commit test goes.

The post-commit test will be at http://qa.drupal.org/pifr/test/26934

rfay’s picture

Status: Needs work » Fixed

Passes the test on checkin: http://qa.drupal.org/pifr/test/26934

So we'll call it good.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.