What this patch offers:

  1. Valid XHTML table markup: month name in <caption>, day headers in <thead>, and only days in <tbody>.
  2. Simplified CSS class structure and less repetition (e.g. .march .fri, .march .day-5)
  3. New feature: CSS class .pad to style padding days (e.g. for removed borders, or grayed background color)

Reasoning

For reasoning, please read:

Jonathan Snook's Blog: Designing Data Part 1: Table structure
aka. Valid XHTML table markup
http://www.snook.ca/archives/html_and_css/designing_data/

Veerle Pieters' Blog: A CSS styled calendar
aka. Easy CSS stylesheet markup
http://veerle.duoh.com/blog/comments/a_css_styled_calendar/

I've already implemented this for my organization.
Hoping you will commit in future release so we don't have to patch manually.

Great module! Thanks! :)

CommentFileSizeAuthor
#2 event_30.patch9.4 KBms2011
#1 event_29.patch1.29 KBms2011
event_28.patch4.3 KBms2011

Comments

ms2011’s picture

ms2011 commented
Title: Valid XHTML, simplified CSS, and a new feature! :) » UPDATE: Valid XHTML, simplified CSS, and a new feature! :)
StatusFileSize
new event_29.patch1.29 KB

What this patch does (after applying the previous patch):

  1. Further simplified CSS and removed duplicates (CSS 'th.days' selector becomes simply 'th', since there's really only one row in THEAD and they all happen to be TH elements).
  2. Improved code added in previous patch by using array_pad() and array_fill() defaults to set .pad class attribute.
ms2011’s picture

ms2011 commented
StatusFileSize
new event_30.patch9.4 KB

In addition to previous patches, updated the other views for Week, Day and Table use the same XHTML table format as the Month view.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Fixed

Mike, I've applied your patches (most of it) to the HEAD branche and will merge it into the Drupal-5 branch. Please don't use tabs in Drupal code.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)